pr review

zeitlinger · zeitlinger · commit c69a836ae9ed · 2025-09-11T13:53:19.000+02:00
diff --git a/instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameDetector.java b/instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameDetector.java
@@ -75,7 +75,7 @@ public Resource createResource(ConfigProperties config) {
     return create();
   }
 
-  public Resource createResource(DeclarativeConfigProperties config) {
+  Resource createResource(DeclarativeConfigProperties config) {
     return create();
   }
 
diff --git a/instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceVersionDetector.java b/instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceVersionDetector.java
@@ -45,7 +45,7 @@ public Resource createResource(ConfigProperties config) {
     return create();
   }
 
-  public Resource createResource(DeclarativeConfigProperties config) {
+  Resource createResource(DeclarativeConfigProperties config) {
     return create();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public Resource createResource(ConfigProperties config) {`
`75`	`75`	`return create();`
`76`	`76`	`}`
`77`	`77`
`78`		`- public Resource createResource(DeclarativeConfigProperties config) {`
	`78`	`+ Resource createResource(DeclarativeConfigProperties config) {`
`79`	`79`	`return create();`
`80`	`80`	`}`
`81`	`81`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public Resource createResource(ConfigProperties config) {`
`45`	`45`	`return create();`
`46`	`46`	`}`
`47`	`47`
`48`		`- public Resource createResource(DeclarativeConfigProperties config) {`
	`48`	`+ Resource createResource(DeclarativeConfigProperties config) {`
`49`	`49`	`return create();`
`50`	`50`	`}`
`51`	`51`