Skip to content

Commit c973fae

Browse files
committed
use the same test header as other tests
1 parent ed6ed7a commit c973fae

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ tasks {
3636
excludeTestsMatching("WrapperSuppressReceiveSpansTest")
3737
}
3838
jvmArgs("-Dotel.instrumentation.messaging.experimental.receive-telemetry.enabled=true")
39-
jvmArgs("-Dotel.instrumentation.messaging.experimental.capture-headers=baggage")
39+
systemProperty("otel.instrumentation.messaging.experimental.capture-headers", "test-message-header")
4040
}
4141

4242
check {

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/AbstractInterceptorsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ void testInterceptors() throws InterruptedException {
5353
new ProducerRecord<>(SHARED_TOPIC, greeting);
5454
producerRecord
5555
.headers()
56+
// add header to test capturing header value as span attribute
57+
.add("test-message-header", "test".getBytes(StandardCharsets.UTF_8))
5658
// adding baggage header in w3c baggage format
5759
.add(
5860
"baggage",

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/InterceptorsTest.java

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,13 @@
1717
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_MESSAGE_BODY_SIZE;
1818
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_OPERATION;
1919
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_SYSTEM;
20-
import static java.util.Arrays.asList;
20+
import static java.util.Collections.singletonList;
2121
import static org.assertj.core.api.Assertions.assertThat;
2222

23-
import io.opentelemetry.api.common.AttributeKey;
2423
import io.opentelemetry.api.trace.SpanContext;
2524
import io.opentelemetry.api.trace.SpanKind;
2625
import io.opentelemetry.sdk.trace.data.LinkData;
2726
import java.nio.charset.StandardCharsets;
28-
import java.util.Arrays;
2927
import java.util.concurrent.atomic.AtomicReference;
3028
import org.assertj.core.api.AbstractLongAssert;
3129
import org.assertj.core.api.AbstractStringAssert;
@@ -47,10 +45,8 @@ void assertTraces() {
4745
.hasParent(trace.getSpan(0))
4846
.hasAttributesSatisfyingExactly(
4947
equalTo(
50-
stringArrayKey("messaging.header.baggage"),
51-
asList(
52-
"test-baggage-key-1=test-baggage-value-1",
53-
"test-baggage-key-2=test-baggage-value-2")),
48+
stringArrayKey("messaging.header.test_message_header"),
49+
singletonList("test")),
5450
equalTo(MESSAGING_SYSTEM, "kafka"),
5551
equalTo(MESSAGING_DESTINATION_NAME, SHARED_TOPIC),
5652
equalTo(MESSAGING_OPERATION, "publish"),
@@ -74,10 +70,8 @@ void assertTraces() {
7470
.hasLinksSatisfying(links -> assertThat(links).isEmpty())
7571
.hasAttributesSatisfyingExactly(
7672
equalTo(
77-
AttributeKey.stringArrayKey("messaging.header.baggage"),
78-
Arrays.asList(
79-
"test-baggage-key-1=test-baggage-value-1",
80-
"test-baggage-key-2=test-baggage-value-2")),
73+
stringArrayKey("messaging.header.test_message_header"),
74+
singletonList("test")),
8175
equalTo(MESSAGING_SYSTEM, "kafka"),
8276
equalTo(MESSAGING_DESTINATION_NAME, SHARED_TOPIC),
8377
equalTo(MESSAGING_OPERATION, "receive"),
@@ -93,10 +87,8 @@ void assertTraces() {
9387
.hasLinks(LinkData.create(producerSpanContext.get()))
9488
.hasAttributesSatisfyingExactly(
9589
equalTo(
96-
AttributeKey.stringArrayKey("messaging.header.baggage"),
97-
Arrays.asList(
98-
"test-baggage-key-1=test-baggage-value-1",
99-
"test-baggage-key-2=test-baggage-value-2")),
90+
stringArrayKey("messaging.header.test_message_header"),
91+
singletonList("test")),
10092
equalTo(MESSAGING_SYSTEM, "kafka"),
10193
equalTo(MESSAGING_DESTINATION_NAME, SHARED_TOPIC),
10294
equalTo(MESSAGING_OPERATION, "process"),

0 commit comments

Comments
 (0)