use HostIncubatingAttributes and remove enabling for java 16, make HostResource attribute constants private

Author: jaydeluca

instrumentation/resources/library/src/main/java/io/opentelemetry/instrumentation/resources/HostResource.java

@@ -17,8 +17,8 @@
 public final class HostResource {
 
   // copied from HostIncubatingAttributes
-  public static final AttributeKey<String> HOST_ARCH = AttributeKey.stringKey("host.arch");
-  public static final AttributeKey<String> HOST_NAME = AttributeKey.stringKey("host.name");
+  private static final AttributeKey<String> HOST_ARCH = AttributeKey.stringKey("host.arch");
+  private static final AttributeKey<String> HOST_NAME = AttributeKey.stringKey("host.name");
 
   private static final Resource INSTANCE = buildResource();
 

instrumentation/resources/library/src/testSecurityManager/java/io/opentelemetry/instrumentation/resources/SecurityManagerResourceTest.java

@@ -9,6 +9,7 @@
 
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.sdk.resources.Resource;
+import io.opentelemetry.semconv.incubating.HostIncubatingAttributes;
 import io.opentelemetry.semconv.incubating.ProcessIncubatingAttributes;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInstance;
@@ -19,14 +20,14 @@
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
 @ExtendWith(SecurityManagerExtension.class)
 @EnabledOnJre(
-    value = {JRE.JAVA_8, JRE.JAVA_11, JRE.JAVA_16},
+    value = {JRE.JAVA_8, JRE.JAVA_11},
     disabledReason = "Java 17 deprecates security manager for removal")
 class SecurityManagerResourceTest {
 
   @Test
   void hostResourceTestEmpty() {
     Attributes attributes = HostResource.buildResource().getAttributes();
-    assertThat(attributes.asMap()).containsOnlyKeys(HostResource.HOST_NAME);
+    assertThat(attributes.asMap()).containsOnlyKeys(HostIncubatingAttributes.HOST_NAME);
   }
 
   @Test