Skip to content

Commit cc90160

Browse files
committed
fix formatting and add required aliases
1 parent d60eaf3 commit cc90160

File tree

7 files changed

+132
-104
lines changed

7 files changed

+132
-104
lines changed

instrumentation/camunda/camunda-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/camunda/v7_0/behavior/CamundaCallableElementActivityBehaviorModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
public class CamundaCallableElementActivityBehaviorModule extends InstrumentationModule {
2121

2222
public CamundaCallableElementActivityBehaviorModule() {
23-
super("camunda", "camunda-behavior", "camunda-behavior-7_18");
23+
super("camunda", "camunda-7.0", "camunda-behavior", "camunda-behavior-7_18");
2424
}
2525

2626
@Override

instrumentation/camunda/camunda-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/camunda/v7_0/jobs/CamundaAsyncContinuationJobHandlerModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
public class CamundaAsyncContinuationJobHandlerModule extends InstrumentationModule {
2020

2121
public CamundaAsyncContinuationJobHandlerModule() {
22-
super("camunda", "camunda-job", "camunda-job-7_18");
22+
super("camunda", "camunda-7.0", "camunda-job", "camunda-job-7_18");
2323
}
2424

2525
@Override

instrumentation/camunda/camunda-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/camunda/v7_0/processes/CamundaProcessInstantiationBuilderModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
public class CamundaProcessInstantiationBuilderModule extends InstrumentationModule {
2020

2121
public CamundaProcessInstantiationBuilderModule() {
22-
super("camunda", "camunda-process", "camunda-process-7_18");
22+
super("camunda", "camunda-7.0", "camunda-process", "camunda-process-7_18");
2323
}
2424

2525
@Override

instrumentation/camunda/camunda-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/camunda/v7_0/task/CamundaTopicSubscriptionManagerModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
public class CamundaTopicSubscriptionManagerModule extends InstrumentationModule {
2020

2121
public CamundaTopicSubscriptionManagerModule() {
22-
super("camunda", "camunda-task", "camunda-task-7_18");
22+
super("camunda", "camunda-7.0", "camunda-task", "camunda-task-7_18");
2323
}
2424

2525
@Override

instrumentation/camunda/camunda-7.0/testing/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@ dependencies {
1111
implementation("io.opentelemetry:opentelemetry-api")
1212
implementation("org.spockframework:spock-core")
1313
implementation("com.h2database:h2:2.2.224")
14-
1514
}
Lines changed: 121 additions & 96 deletions
Original file line numberDiff line numberDiff line change
@@ -1,116 +1,141 @@
1-
package io.opentelemetry.instrumentation.camunda.v7_0;
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
25

3-
import static org.junit.jupiter.api.Assertions.assertNotNull;
4-
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
6+
package io.opentelemetry.instrumentation.camunda.v7_0;
57

68
import static io.opentelemetry.api.common.AttributeKey.stringKey;
9+
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
710
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.satisfies;
11+
import static org.junit.jupiter.api.Assertions.assertNotNull;
812

9-
import org.junit.jupiter.api.extension.RegisterExtension;
10-
13+
import io.opentelemetry.api.trace.SpanKind;
1114
import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension;
1215
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
13-
16+
import org.camunda.bpm.engine.HistoryService;
1417
import org.camunda.bpm.engine.ProcessEngine;
1518
import org.camunda.bpm.engine.ProcessEngineConfiguration;
16-
import org.camunda.bpm.engine.HistoryService;
1719
import org.camunda.bpm.engine.RuntimeService;
1820
import org.camunda.bpm.engine.repository.Deployment;
1921
import org.camunda.bpm.engine.runtime.ProcessInstance;
2022
import org.camunda.bpm.engine.test.mock.Mocks;
2123
import org.junit.jupiter.api.AfterEach;
2224
import org.junit.jupiter.api.BeforeEach;
2325
import org.junit.jupiter.api.Test;
24-
25-
import io.opentelemetry.api.trace.SpanKind;
26+
import org.junit.jupiter.api.extension.RegisterExtension;
2627

2728
public abstract class AbstractCamundaTest {
2829

29-
@RegisterExtension
30-
private static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
31-
32-
private ProcessEngine processEngine;
33-
private RuntimeService runtimeService;
34-
private HistoryService historyService;
35-
36-
@BeforeEach
37-
void setUp() {
38-
processEngine = ProcessEngineConfiguration.createStandaloneInMemProcessEngineConfiguration()
39-
.buildProcessEngine();
40-
runtimeService = processEngine.getRuntimeService();
41-
historyService = processEngine.getHistoryService();
42-
43-
Product mockDelegate = new Product();
44-
45-
Mocks.register("Product", mockDelegate);
46-
}
47-
48-
@AfterEach
49-
void tearDown() {
50-
processEngine.close();
51-
}
52-
53-
@Test
54-
void testProcessExecutionAllSuccess() {
55-
Deployment deployment = processEngine.getRepositoryService().createDeployment()
56-
.addClasspathResource("testMainProcess.bpmn").addClasspathResource("customerSubProcess.bpmn")
57-
.deploy();
58-
59-
ProcessInstance processInstance = runtimeService.startProcessInstanceByKey("testMainProcess");
60-
61-
assertNotNull(processInstance);
62-
63-
testing.waitAndAssertTracesWithoutScopeVersionVerification(
64-
trace ->
65-
trace.hasSpansSatisfyingExactly(
66-
span ->
67-
span.hasName("testMainProcess")
68-
.hasKind(SpanKind.INTERNAL)
69-
.hasAttributesSatisfyingExactly(
70-
equalTo(stringKey("camunda.processdefinitionkey"), "testMainProcess")),
71-
span ->
72-
span.hasName("Get Product Info Task")
73-
.hasKind(SpanKind.INTERNAL)
74-
.hasAttributesSatisfyingExactly(
75-
equalTo(stringKey("camunda.activityid"), "getProductInfo"),
76-
satisfies(stringKey("camunda.processdefinitionid"), value -> value.startsWith("testMainProcess")),
77-
satisfies(stringKey("camunda.processinstanceid"), value -> assertNotNull(value)),
78-
equalTo(stringKey("camunda.activityname"), "Get Product Info")),
79-
span ->
80-
span.hasName("Verify Customer Task")
81-
.hasKind(SpanKind.INTERNAL)
82-
.hasAttributesSatisfyingExactly(
83-
equalTo(stringKey("camunda.activityid"), "verifyCustomer"),
84-
satisfies(stringKey("camunda.processdefinitionid"), value -> value.startsWith("testMainProcess")),
85-
satisfies(stringKey("camunda.processinstanceid"), value -> assertNotNull(value)),
86-
equalTo(stringKey("camunda.activityname"), "Verify Customer")),
87-
span ->
88-
span.hasName("End Event")
89-
.hasKind(SpanKind.INTERNAL)
90-
.hasAttributesSatisfyingExactly(
91-
satisfies(stringKey("camunda.processdefinitionid"), value -> value.startsWith("customerSubProcess")),
92-
equalTo(stringKey("camunda.activityid"), "Event_12mjag6"),
93-
satisfies(stringKey("camunda.processinstanceid"), value -> assertNotNull(value)),
94-
equalTo(stringKey("camunda.activityname"), "End")),
95-
span ->
96-
span.hasName("Send Product Info Task")
97-
.hasKind(SpanKind.INTERNAL)
98-
.hasAttributesSatisfyingExactly(
99-
equalTo(stringKey("camunda.activityid"), "sendProductInfo"),
100-
satisfies(stringKey("camunda.processdefinitionid"), value -> value.startsWith("testMainProcess")),
101-
satisfies(stringKey("camunda.processinstanceid"), value -> assertNotNull(value)),
102-
equalTo(stringKey("camunda.activityname"), "Send Product Info")),
103-
span ->
104-
span.hasName("End Event")
105-
.hasKind(SpanKind.INTERNAL)
106-
.hasAttributesSatisfyingExactly(
107-
satisfies(stringKey("camunda.processdefinitionid"), value -> value.startsWith("testMainProcess")),
108-
equalTo(stringKey("camunda.activityid"), "Event_110t6od"),
109-
satisfies(stringKey("camunda.processinstanceid"), value -> assertNotNull(value)),
110-
equalTo(stringKey("camunda.activityname"), "End"))));
111-
112-
historyService.deleteHistoricProcessInstanceIfExists(processInstance.getId());
113-
processEngine.getRepositoryService().deleteDeployment(deployment.getId(), true);
114-
}
115-
30+
@RegisterExtension
31+
private static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
32+
33+
private ProcessEngine processEngine;
34+
private RuntimeService runtimeService;
35+
private HistoryService historyService;
36+
37+
@BeforeEach
38+
void setUp() {
39+
processEngine =
40+
ProcessEngineConfiguration.createStandaloneInMemProcessEngineConfiguration()
41+
.buildProcessEngine();
42+
runtimeService = processEngine.getRuntimeService();
43+
historyService = processEngine.getHistoryService();
44+
45+
Product mockDelegate = new Product();
46+
47+
Mocks.register("Product", mockDelegate);
48+
}
49+
50+
@AfterEach
51+
void tearDown() {
52+
processEngine.close();
53+
}
54+
55+
@Test
56+
void testProcessExecutionAllSuccess() {
57+
Deployment deployment =
58+
processEngine
59+
.getRepositoryService()
60+
.createDeployment()
61+
.addClasspathResource("testMainProcess.bpmn")
62+
.addClasspathResource("customerSubProcess.bpmn")
63+
.deploy();
64+
65+
ProcessInstance processInstance = runtimeService.startProcessInstanceByKey("testMainProcess");
66+
67+
assertNotNull(processInstance);
68+
69+
testing.waitAndAssertTracesWithoutScopeVersionVerification(
70+
trace ->
71+
trace.hasSpansSatisfyingExactly(
72+
span ->
73+
span.hasName("testMainProcess")
74+
.hasKind(SpanKind.INTERNAL)
75+
.hasAttributesSatisfyingExactly(
76+
equalTo(stringKey("camunda.processdefinitionkey"), "testMainProcess")),
77+
span ->
78+
span.hasName("Get Product Info Task")
79+
.hasKind(SpanKind.INTERNAL)
80+
.hasAttributesSatisfyingExactly(
81+
equalTo(stringKey("camunda.activityid"), "getProductInfo"),
82+
satisfies(
83+
stringKey("camunda.processdefinitionid"),
84+
value -> value.startsWith("testMainProcess")),
85+
satisfies(
86+
stringKey("camunda.processinstanceid"),
87+
value -> assertNotNull(value)),
88+
equalTo(stringKey("camunda.activityname"), "Get Product Info")),
89+
span ->
90+
span.hasName("Verify Customer Task")
91+
.hasKind(SpanKind.INTERNAL)
92+
.hasAttributesSatisfyingExactly(
93+
equalTo(stringKey("camunda.activityid"), "verifyCustomer"),
94+
satisfies(
95+
stringKey("camunda.processdefinitionid"),
96+
value -> value.startsWith("testMainProcess")),
97+
satisfies(
98+
stringKey("camunda.processinstanceid"),
99+
value -> assertNotNull(value)),
100+
equalTo(stringKey("camunda.activityname"), "Verify Customer")),
101+
span ->
102+
span.hasName("End Event")
103+
.hasKind(SpanKind.INTERNAL)
104+
.hasAttributesSatisfyingExactly(
105+
satisfies(
106+
stringKey("camunda.processdefinitionid"),
107+
value -> value.startsWith("customerSubProcess")),
108+
equalTo(stringKey("camunda.activityid"), "Event_12mjag6"),
109+
satisfies(
110+
stringKey("camunda.processinstanceid"),
111+
value -> assertNotNull(value)),
112+
equalTo(stringKey("camunda.activityname"), "End")),
113+
span ->
114+
span.hasName("Send Product Info Task")
115+
.hasKind(SpanKind.INTERNAL)
116+
.hasAttributesSatisfyingExactly(
117+
equalTo(stringKey("camunda.activityid"), "sendProductInfo"),
118+
satisfies(
119+
stringKey("camunda.processdefinitionid"),
120+
value -> value.startsWith("testMainProcess")),
121+
satisfies(
122+
stringKey("camunda.processinstanceid"),
123+
value -> assertNotNull(value)),
124+
equalTo(stringKey("camunda.activityname"), "Send Product Info")),
125+
span ->
126+
span.hasName("End Event")
127+
.hasKind(SpanKind.INTERNAL)
128+
.hasAttributesSatisfyingExactly(
129+
satisfies(
130+
stringKey("camunda.processdefinitionid"),
131+
value -> value.startsWith("testMainProcess")),
132+
equalTo(stringKey("camunda.activityid"), "Event_110t6od"),
133+
satisfies(
134+
stringKey("camunda.processinstanceid"),
135+
value -> assertNotNull(value)),
136+
equalTo(stringKey("camunda.activityname"), "End"))));
137+
138+
historyService.deleteHistoricProcessInstanceIfExists(processInstance.getId());
139+
processEngine.getRepositoryService().deleteDeployment(deployment.getId(), true);
140+
}
116141
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
16
package io.opentelemetry.instrumentation.camunda.v7_0;
27

38
import org.camunda.bpm.engine.delegate.DelegateExecution;
49

510
public class Product {
611

7-
public void getInfo(DelegateExecution execution) {
8-
}
9-
}
12+
public void getInfo(DelegateExecution execution) {}
13+
}

0 commit comments

Comments
 (0)