Skip to content

Commit cd0a023

Browse files
committed
fix
1 parent b4e55cc commit cd0a023

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

conventions/src/main/kotlin/otel.nullaway-conventions.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ tasks {
2222
options.errorprone.nullaway {
2323
severity.set(CheckSeverity.ERROR)
2424
customInitializerAnnotations.add("org.openjdk.jmh.annotations.Setup")
25+
excludedFieldAnnotations.add("org.mockito.Mock")
2526
}
2627
}
2728
}

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,12 @@ public static <REQUEST, RESPONSE> MessagingAttributesExtractorBuilder<REQUEST, R
7676
}
7777

7878
private final MessagingAttributesGetter<REQUEST, RESPONSE> getter;
79-
private final MessageOperation operation;
79+
@Nullable private final MessageOperation operation;
8080
private final List<String> capturedHeaders;
8181

8282
MessagingAttributesExtractor(
8383
MessagingAttributesGetter<REQUEST, RESPONSE> getter,
84-
MessageOperation operation,
84+
@Nullable MessageOperation operation,
8585
List<String> capturedHeaders) {
8686
this.getter = getter;
8787
this.operation = operation;

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractorBuilder.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
import com.google.errorprone.annotations.CanIgnoreReturnValue;
1111
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
12+
import javax.annotation.Nullable;
1213
import java.util.ArrayList;
1314
import java.util.Collection;
1415
import java.util.List;
@@ -17,11 +18,11 @@
1718
public final class MessagingAttributesExtractorBuilder<REQUEST, RESPONSE> {
1819

1920
final MessagingAttributesGetter<REQUEST, RESPONSE> getter;
20-
final MessageOperation operation;
21+
@Nullable final MessageOperation operation;
2122
List<String> capturedHeaders = emptyList();
2223

2324
MessagingAttributesExtractorBuilder(
24-
MessagingAttributesGetter<REQUEST, RESPONSE> getter, MessageOperation operation) {
25+
MessagingAttributesGetter<REQUEST, RESPONSE> getter, @Nullable MessageOperation operation) {
2526
this.getter = getter;
2627
this.operation = operation;
2728
}

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,13 @@ enum TestGetter implements MessagingAttributesGetter<Map<String, String>, String
135135
INSTANCE;
136136

137137
@Override
138+
@Nullable
138139
public String getSystem(Map<String, String> request) {
139140
return request.get("system");
140141
}
141142

142143
@Override
144+
@Nullable
143145
public String getDestination(Map<String, String> request) {
144146
return request.get("destination");
145147
}
@@ -161,6 +163,7 @@ public boolean isAnonymousDestination(Map<String, String> request) {
161163
}
162164

163165
@Override
166+
@Nullable
164167
public String getConversationId(Map<String, String> request) {
165168
return request.get("conversationId");
166169
}
@@ -180,6 +183,7 @@ public Long getMessageEnvelopeSize(Map<String, String> request) {
180183
}
181184

182185
@Override
186+
@Nullable
183187
public String getMessageId(Map<String, String> request, String response) {
184188
return response;
185189
}

0 commit comments

Comments
 (0)