Skip to content

Commit d22c846

Browse files
committed
Address review comments
1 parent 71afc51 commit d22c846

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

instrumentation/async-http-client/async-http-client-1-common/javaagent/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ plugins {
33
}
44

55
dependencies {
6-
compileOnly("com.ning:async-http-client:1.8.3")
6+
compileOnly("com.ning:async-http-client:1.8.0")
77

88
compileOnly("com.google.auto.value:auto-value-annotations")
99
annotationProcessor("com.google.auto.value:auto-value")

instrumentation/async-http-client/async-http-client-1.8/javaagent/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ muzzle {
1414
dependencies {
1515
implementation(project(":instrumentation:async-http-client:async-http-client-1-common:javaagent"))
1616

17-
library("com.ning:async-http-client:1.8.3")
17+
library("com.ning:async-http-client:1.8.0")
1818

1919
compileOnly("com.google.auto.value:auto-value-annotations")
2020
annotationProcessor("com.google.auto.value:auto-value")

instrumentation/async-http-client/async-http-client-1.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/v1_8/AsyncHttpClientSingletons.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,9 @@
1313
public final class AsyncHttpClientSingletons {
1414
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.async-http-client-1.8";
1515

16-
private static final Instrumenter<Request, Response> INSTRUMENTER;
17-
18-
static {
19-
INSTRUMENTER =
20-
AsyncHttpClientInstrumenterFactory.create(
21-
INSTRUMENTATION_NAME, AsyncHttpClient18Helper.INSTANCE);
22-
}
16+
private static final Instrumenter<Request, Response> INSTRUMENTER =
17+
AsyncHttpClientInstrumenterFactory.create(
18+
INSTRUMENTATION_NAME, AsyncHttpClient18Helper.INSTANCE);
2319

2420
public static Instrumenter<Request, Response> instrumenter() {
2521
return INSTRUMENTER;

instrumentation/async-http-client/async-http-client-1.9/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/v1_9/AsyncHttpClientSingletons.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,9 @@
1313
public final class AsyncHttpClientSingletons {
1414
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.async-http-client-1.9";
1515

16-
private static final Instrumenter<Request, Response> INSTRUMENTER;
17-
18-
static {
19-
INSTRUMENTER =
20-
AsyncHttpClientInstrumenterFactory.create(
21-
INSTRUMENTATION_NAME, AsyncHttpClient19Helper.INSTANCE);
22-
}
16+
private static final Instrumenter<Request, Response> INSTRUMENTER =
17+
AsyncHttpClientInstrumenterFactory.create(
18+
INSTRUMENTATION_NAME, AsyncHttpClient19Helper.INSTANCE);
2319

2420
public static Instrumenter<Request, Response> instrumenter() {
2521
return INSTRUMENTER;

0 commit comments

Comments
 (0)