Skip to content

Commit d4575d8

Browse files
committed
address review comments
1 parent 645e3e3 commit d4575d8

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

docs/supported-libraries.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ These are the supported libraries and frameworks:
126126
| [Spark Web Framework](https://github.com/perwendel/spark) | 2.3+ | N/A | Provides `http.route` [2] |
127127
| [Spring Batch](https://spring.io/projects/spring-batch) | 3.0+ (not including 5.0+ yet) | N/A | none |
128128
| [Spring Boot](https://spring.io/projects/spring-boot) | | [opentelemetry-spring-boot-resources](https://opentelemetry.io/docs/zero-code/java/spring-boot/) | none |
129-
| [Spring Cloud AWS](hhttps://spring.io/projects/spring-cloud-aws) | 3.0+ | N/A | [Messaging Spans] |
129+
| [Spring Cloud AWS](https://spring.io/projects/spring-cloud-aws) | 3.0+ | N/A | [Messaging Spans] |
130130
| [Spring Cloud Gateway](https://github.com/spring-cloud/spring-cloud-gateway) | 2.0+ | N/A | Provides `http.route` [2] |
131131
| [Spring Core](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/core/package-summary.html) | 2.0+ | N/A | Context propagation |
132132
| [Spring Data](https://spring.io/projects/spring-data) | 1.8+ | N/A | none |

instrumentation/spring/spring-cloud-aws-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/aws/MessagingMessageListenerAdapterInstrumentation.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public void transform(TypeTransformer transformer) {
2727
transformer.applyAdviceToMethod(
2828
named("onMessage").and(takesArgument(0, named("org.springframework.messaging.Message"))),
2929
this.getClass().getName() + "$OnMessageAdvice");
30+
// TODO: onMessage(Collection<Message<T>> messages) not instrumented
3031
}
3132

3233
@SuppressWarnings("unused")

instrumentation/spring/spring-cloud-aws-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/aws/AwsSqsTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,10 @@
3131
import org.junit.jupiter.api.AfterAll;
3232
import org.junit.jupiter.api.BeforeAll;
3333
import org.junit.jupiter.api.Test;
34-
import org.junit.jupiter.api.extension.ExtendWith;
3534
import org.junit.jupiter.api.extension.RegisterExtension;
3635
import org.springframework.beans.factory.annotation.Autowired;
3736
import org.springframework.boot.test.context.SpringBootTest;
38-
import org.springframework.test.context.junit.jupiter.SpringExtension;
3937

40-
@ExtendWith(SpringExtension.class)
4138
@SpringBootTest(
4239
webEnvironment = SpringBootTest.WebEnvironment.NONE,
4340
classes = AwsSqsTestApplication.class)

0 commit comments

Comments
 (0)