Skip to content

Commit d6fa683

Browse files
committed
string
1 parent 4faca8c commit d6fa683

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/ConfigPropertiesUtil.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,7 @@ private static DeclarativeConfigProperties getDeclarativeConfigNode(
161161
return null;
162162
}
163163

164-
// Visible for testing
165-
static String toSystemProperty(String[] propertyName) {
164+
public static String toSystemProperty(String[] propertyName) {
166165
return "otel.instrumentation." + String.join(".", propertyName).replace('_', '-');
167166
}
168167

instrumentation/aws-sdk/aws-sdk-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/awssdk/v2_2/AwsSdkSingletons.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package io.opentelemetry.javaagent.instrumentation.awssdk.v2_2;
77

8+
import io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil;
89
import io.opentelemetry.instrumentation.awssdk.v2_2.AwsSdkTelemetry;
910
import io.opentelemetry.instrumentation.awssdk.v2_2.internal.AbstractAwsSdkTelemetryFactory;
1011
import io.opentelemetry.javaagent.bootstrap.internal.AgentInstrumentationConfig;
@@ -32,8 +33,9 @@ protected boolean messagingReceiveInstrumentationEnabled() {
3233
}
3334

3435
@Override
35-
protected boolean getBoolean(String name, boolean defaultValue) {
36-
return AgentInstrumentationConfig.get().getBoolean(name, defaultValue);
36+
protected boolean getBoolean(boolean defaultValue, String... name) {
37+
return AgentInstrumentationConfig.get()
38+
.getBoolean(ConfigPropertiesUtil.toSystemProperty(name), defaultValue);
3739
}
3840
}
3941

instrumentation/aws-sdk/aws-sdk-2.2/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/autoconfigure/AwsSdkSingletons.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,23 @@ private static class AwsSdkTelemetryFactory extends AbstractAwsSdkTelemetryFacto
2626
@Override
2727
protected List<String> getCapturedHeaders() {
2828
return ConfigPropertiesUtil.getList(
29-
GlobalOpenTelemetry.get(),
30-
emptyList(),
31-
"messaging", "experimental", "capture_headers");
29+
GlobalOpenTelemetry.get(), emptyList(), "messaging", "experimental", "capture_headers");
3230
}
3331

3432
@Override
3533
protected boolean messagingReceiveInstrumentationEnabled() {
3634
return ConfigPropertiesUtil.getBoolean(
3735
GlobalOpenTelemetry.get(),
3836
false,
39-
"messaging", "experimental", "receive_telemetry", "enabled");
37+
"messaging",
38+
"experimental",
39+
"receive_telemetry",
40+
"enabled");
4041
}
4142

4243
@Override
43-
protected boolean getBoolean(String name, boolean defaultValue) {
44-
return ConfigPropertiesUtil.getBoolean(name, defaultValue);
44+
protected boolean getBoolean(boolean defaultValue, String... name) {
45+
return ConfigPropertiesUtil.getBoolean(GlobalOpenTelemetry.get(), defaultValue, name);
4546
}
4647
}
4748

instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AbstractAwsSdkTelemetryFactory.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,21 @@ public abstract class AbstractAwsSdkTelemetryFactory {
1717
protected abstract List<String> getCapturedHeaders();
1818

1919
private boolean captureExperimentalSpanAttributes() {
20-
return getBoolean(false, "otel.instrumentation.aws-sdk.experimental-span-attributes");
20+
return getBoolean(false, "aws_sdk", "experimental_span_attributes");
2121
}
2222

2323
protected abstract boolean messagingReceiveInstrumentationEnabled();
2424

2525
private boolean useMessagingPropagator() {
26-
return getBoolean(
27-
false, "otel.instrumentation.aws-sdk.experimental-use-propagator-for-messaging");
26+
return getBoolean(false, "aws_sdk", "experimental_use_propagator_for_messaging");
2827
}
2928

3029
private boolean recordIndividualHttpError() {
31-
return getBoolean(
32-
false, "otel.instrumentation.aws-sdk.experimental-record-individual-http-error");
30+
return getBoolean(false, "aws_sdk", "experimental_record_individual_http_error");
3331
}
3432

3533
private boolean genaiCaptureMessageContent() {
36-
return getBoolean(false, "otel.instrumentation.genai.capture-message-content");
34+
return getBoolean(false, "genai", "capture_message_content");
3735
}
3836

3937
protected abstract boolean getBoolean(boolean defaultValue, String... name);

0 commit comments

Comments
 (0)