redisson 3.17

Author: SylvainJuge

instrumentation/redisson/redisson-3.17/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/v3_17/RedisCommandDataInstrumentation.java

@@ -16,6 +16,8 @@
 import net.bytebuddy.asm.Advice;
 import net.bytebuddy.description.type.TypeDescription;
 import net.bytebuddy.matcher.ElementMatcher;
+import net.bytebuddy.asm.Advice.AssignReturned;
+import net.bytebuddy.asm.Advice.AssignReturned.ToArguments.ToArgument;
 
 public class RedisCommandDataInstrumentation implements TypeInstrumentation {
 
@@ -35,10 +37,11 @@ public void transform(TypeTransformer transformer) {
   @SuppressWarnings("unused")
   public static class WrapCompletableFutureAdvice {
 
+    @AssignReturned.ToArguments(@ToArgument(0))
     @Advice.OnMethodEnter(suppress = Throwable.class)
-    public static void onEnter(
-        @Advice.Argument(value = 0, readOnly = false) CompletableFuture<?> completableFuture) {
-      completableFuture = CompletableFutureWrapper.wrap(completableFuture);
+    public static CompletableFuture<?> onEnter(
+        @Advice.Argument(0) CompletableFuture<?> completableFuture) {
+      return CompletableFutureWrapper.wrap(completableFuture);
     }
   }
 }

instrumentation/redisson/redisson-3.17/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/v3_17/RedisConnectionInstrumentation.java

@@ -22,6 +22,7 @@
 import net.bytebuddy.description.type.TypeDescription;
 import net.bytebuddy.matcher.ElementMatcher;
 import org.redisson.client.RedisConnection;
+import javax.annotation.Nullable;
 
 public class RedisConnectionInstrumentation implements TypeInstrumentation {
   @Override
@@ -38,47 +39,64 @@ public void transform(TypeTransformer transformer) {
   @SuppressWarnings("unused")
   public static class SendAdvice {
 
-    @Advice.OnMethodEnter(suppress = Throwable.class)
-    public static void onEnter(
-        @Advice.This RedisConnection connection,
-        @Advice.Argument(0) Object arg,
-        @Advice.Local("otelRequest") RedissonRequest request,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
+    public static class AdviceScope {
+      private final RedissonRequest request;
+      private final Context context;
+      private final Scope scope;
 
-      Context parentContext = currentContext();
-      InetSocketAddress remoteAddress = (InetSocketAddress) connection.getChannel().remoteAddress();
-      request = RedissonRequest.create(remoteAddress, arg);
-      PromiseWrapper<?> promise = request.getPromiseWrapper();
-      if (promise == null) {
-        return;
+      public AdviceScope(RedissonRequest request, Context context, Scope scope) {
+        this.request = request;
+        this.context = context;
+        this.scope = scope;
       }
-      if (!instrumenter().shouldStart(parentContext, request)) {
-        return;
+
+      @Nullable
+      public static AdviceScope start(RedisConnection connection, Object arg) {
+        Context parentContext = currentContext();
+        InetSocketAddress remoteAddress = (InetSocketAddress) connection.getChannel()
+            .remoteAddress();
+        RedissonRequest request = RedissonRequest.create(remoteAddress, arg);
+        PromiseWrapper<?> promise = request.getPromiseWrapper();
+        if (promise == null) {
+          return null;
+        }
+        if (!instrumenter().shouldStart(parentContext, request)) {
+          return null;
+        }
+
+        Context context = instrumenter().start(parentContext, request);
+        Scope scope = context.makeCurrent();
+
+        promise.setEndOperationListener(
+            new EndOperationListener<>(instrumenter(), context, request));
+        return new AdviceScope(request, context, scope);
       }
 
-      context = instrumenter().start(parentContext, request);
-      scope = context.makeCurrent();
+      public void end(@Nullable Throwable throwable) {
+        scope.close();
+        if (throwable != null) {
+          instrumenter().end(context, request, null, throwable);
+        }
+        // span ended in EndOperationListener
+      }
+    }
+
+    @Nullable
+    @Advice.OnMethodEnter(suppress = Throwable.class)
+    public static AdviceScope onEnter(
+        @Advice.This RedisConnection connection,
+        @Advice.Argument(0) Object arg) {
+      return AdviceScope.start(connection, arg);
 
-      promise.setEndOperationListener(new EndOperationListener<>(instrumenter(), context, request));
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
     public static void stopSpan(
-        @Advice.Thrown Throwable throwable,
-        @Advice.Local("otelRequest") RedissonRequest request,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
-
-      if (scope == null) {
-        return;
-      }
-      scope.close();
-
-      if (throwable != null) {
-        instrumenter().end(context, request, null, throwable);
+        @Advice.Thrown @Nullable Throwable throwable,
+        @Advice.Enter @Nullable AdviceScope adviceScope) {
+      if (adviceScope != null) {
+        adviceScope.end(throwable);
       }
-      // span ended in EndOperationListener
     }
   }
 }

instrumentation/redisson/redisson-3.17/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/v3_17/RedissonInstrumentationModule.java

@@ -12,10 +12,11 @@
 import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import java.util.List;
+import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
 import net.bytebuddy.matcher.ElementMatcher;
 
 @AutoService(InstrumentationModule.class)
-public class RedissonInstrumentationModule extends InstrumentationModule {
+public class RedissonInstrumentationModule extends InstrumentationModule implements ExperimentalInstrumentationModule {
 
   public RedissonInstrumentationModule() {
     super("redisson", "redisson-3.17");
@@ -30,4 +31,9 @@ public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
   public List<TypeInstrumentation> typeInstrumentations() {
     return asList(new RedisConnectionInstrumentation(), new RedisCommandDataInstrumentation());
   }
+
+  @Override
+  public boolean isIndyReady() {
+    return true;
+  }
 }