Skip to content

Commit d8da949

Browse files
laurittrask
andauthored
Remove usages of classes shaded in testcontainers from tests (#8551)
Co-authored-by: Trask Stalnaker <[email protected]>
1 parent 2a68a47 commit d8da949

File tree

5 files changed

+15
-21
lines changed

5 files changed

+15
-21
lines changed

instrumentation/camel-2.20/javaagent/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/aws/S3CamelTest.groovy

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
package io.opentelemetry.javaagent.instrumentation.apachecamel.aws
77

88
import io.opentelemetry.instrumentation.test.AgentInstrumentationSpecification
9-
import org.testcontainers.shaded.com.google.common.collect.ImmutableMap
109
import spock.lang.Ignore
1110
import spock.lang.Shared
1211

@@ -22,7 +21,7 @@ class S3CamelTest extends AgentInstrumentationSpecification {
2221
setup:
2322
String bucketName = "bucket-test-s3-sqs-camel"
2423
String queueName = "s3SqsCamelTest"
25-
def camelApp = new CamelSpringApp(awsConnector, S3Config, ImmutableMap.of("bucketName", bucketName, "queueName", queueName))
24+
def camelApp = new CamelSpringApp(awsConnector, S3Config, [bucketName: bucketName, queueName: queueName])
2625

2726
def queueUrl = setupTestInfrastructure(queueName, bucketName)
2827
waitAndClearSetupTraces(queueUrl, queueName, bucketName)

instrumentation/camel-2.20/javaagent/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/aws/SnsCamelTest.groovy

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
package io.opentelemetry.javaagent.instrumentation.apachecamel.aws
77

88
import io.opentelemetry.instrumentation.test.AgentInstrumentationSpecification
9-
import org.testcontainers.shaded.com.google.common.collect.ImmutableMap
109
import spock.lang.Ignore
1110
import spock.lang.Shared
1211

@@ -22,7 +21,7 @@ class SnsCamelTest extends AgentInstrumentationSpecification {
2221
setup:
2322
String topicName = "snsCamelTest"
2423
String queueName = "snsCamelTest"
25-
def camelApp = new CamelSpringApp(awsConnector, SnsConfig, ImmutableMap.of("topicName", topicName, "queueName", queueName))
24+
def camelApp = new CamelSpringApp(awsConnector, SnsConfig, [topicName: topicName, queueName: queueName])
2625

2726
def (queueUrl, topicArn) = setupTestInfrastructure(queueName, topicName)
2827
waitAndClearSetupTraces(queueUrl, queueName)
@@ -59,7 +58,7 @@ class SnsCamelTest extends AgentInstrumentationSpecification {
5958
setup:
6059
String topicName = "snsCamelTest"
6160
String queueName = "snsCamelTest"
62-
def camelApp = new CamelSpringApp(awsConnector, SnsConfig, ImmutableMap.of("topicName", topicName, "queueName", queueName))
61+
def camelApp = new CamelSpringApp(awsConnector, SnsConfig, [topicName: topicName, queueName: queueName])
6362

6463
def (queueUrl, topicArn) = setupTestInfrastructure(queueName, topicName)
6564
waitAndClearSetupTraces(queueUrl, queueName)

instrumentation/camel-2.20/javaagent/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/aws/SqsCamelTest.groovy

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
package io.opentelemetry.javaagent.instrumentation.apachecamel.aws
77

88
import io.opentelemetry.instrumentation.test.AgentInstrumentationSpecification
9-
import org.testcontainers.shaded.com.google.common.collect.ImmutableMap
109
import spock.lang.Shared
1110

1211
import static io.opentelemetry.api.trace.SpanKind.CONSUMER
@@ -24,7 +23,7 @@ class SqsCamelTest extends AgentInstrumentationSpecification {
2423
def "camel SQS producer - camel SQS consumer"() {
2524
setup:
2625
String queueName = "sqsCamelTest"
27-
def camelApp = new CamelSpringApp(awsConnector, SqsConfig, ImmutableMap.of("queueName", queueName))
26+
def camelApp = new CamelSpringApp(awsConnector, SqsConfig, ["queueName": queueName])
2827
def queueUrl = awsConnector.createQueue(queueName)
2928

3029
waitAndClearSetupTraces(queueUrl, queueName)
@@ -59,7 +58,7 @@ class SqsCamelTest extends AgentInstrumentationSpecification {
5958
def "AWS SDK SQS producer - camel SQS consumer"() {
6059
setup:
6160
String queueName = "sqsCamelTest"
62-
def camelApp = new CamelSpringApp(awsConnector, SqsConfig, ImmutableMap.of("queueName", queueName))
61+
def camelApp = new CamelSpringApp(awsConnector, SqsConfig, ["queueName": queueName])
6362
def queueUrl = awsConnector.createQueue(queueName)
6463

6564
waitAndClearSetupTraces(queueUrl, queueName)
@@ -95,7 +94,7 @@ class SqsCamelTest extends AgentInstrumentationSpecification {
9594
def "camel SQS producer - AWS SDK SQS consumer"() {
9695
setup:
9796
String queueName = "sqsCamelTestSdkConsumer"
98-
def camelApp = new CamelSpringApp(awsConnector, SqsConfig, ImmutableMap.of("queueSdkConsumerName", queueName))
97+
def camelApp = new CamelSpringApp(awsConnector, SqsConfig, [queueSdkConsumerName: queueName])
9998
def queueUrl = awsConnector.createQueue(queueName)
10099

101100
waitAndClearSetupTraces(queueUrl, queueName)

instrumentation/guava-10.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/guava/v10_0/BaseGuavaWithSpanTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55

66
package io.opentelemetry.javaagent.instrumentation.guava.v10_0;
77

8+
import com.google.common.base.Throwables;
89
import com.google.common.util.concurrent.Futures;
910
import com.google.common.util.concurrent.ListenableFuture;
1011
import com.google.common.util.concurrent.SettableFuture;
1112
import io.opentelemetry.javaagent.instrumentation.otelannotations.AbstractWithSpanTest;
12-
import org.testcontainers.shaded.com.google.common.base.Throwables;
1313

1414
abstract class BaseGuavaWithSpanTest
1515
extends AbstractWithSpanTest<SettableFuture<String>, ListenableFuture<String>> {

instrumentation/spring/spring-webflux/spring-webflux-5.0/javaagent/src/test/java/server/base/SpringWebFluxServerTest.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@
1414
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
1515
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
1616
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
17+
import java.util.HashMap;
18+
import java.util.Map;
1719
import org.junit.jupiter.api.extension.RegisterExtension;
1820
import org.springframework.boot.SpringApplication;
1921
import org.springframework.context.ConfigurableApplicationContext;
20-
import org.testcontainers.shaded.com.google.common.collect.ImmutableMap;
2122

2223
public abstract class SpringWebFluxServerTest
2324
extends AbstractHttpServerTest<ConfigurableApplicationContext> {
@@ -33,16 +34,12 @@ public abstract class SpringWebFluxServerTest
3334
@Override
3435
public ConfigurableApplicationContext setupServer() {
3536
SpringApplication app = new SpringApplication(getApplicationClass());
36-
app.setDefaultProperties(
37-
ImmutableMap.of(
38-
"server.port",
39-
port,
40-
"server.context-path",
41-
getContextPath(),
42-
"server.servlet.contextPath",
43-
getContextPath(),
44-
"server.error.include-message",
45-
"always"));
37+
Map<String, Object> properties = new HashMap<>();
38+
properties.put("server.port", port);
39+
properties.put("server.context-path", getContextPath());
40+
properties.put("server.servlet.contextPath", getContextPath());
41+
properties.put("server.error.include-message", "always");
42+
app.setDefaultProperties(properties);
4643
return app.run();
4744
}
4845

0 commit comments

Comments
 (0)