Skip to content

Commit d93fc76

Browse files
authored
Don't require internal class javadoc on test classes (#14281)
1 parent 715303f commit d93fc76

File tree

5 files changed

+1
-4
lines changed

5 files changed

+1
-4
lines changed

conventions/src/main/kotlin/otel.errorprone-conventions.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ tasks {
140140
if ((project.path.endsWith(":testing") || name.contains("Test")) && !project.name.equals("custom-checks")) {
141141
// This check causes too many failures, ignore the ones in tests
142142
disable("OtelCanIgnoreReturnValueSuggester")
143+
disable("OtelInternalJavadoc")
143144
}
144145
}
145146
}

instrumentation/kafka/kafka-clients/kafka-clients-0.11/testing/src/main/java/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/AbstractOpenTelemetryMetricsReporterTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
import org.testcontainers.kafka.KafkaContainer;
5858
import org.testcontainers.utility.DockerImageName;
5959

60-
@SuppressWarnings("OtelInternalJavadoc")
6160
@Testcontainers
6261
public abstract class AbstractOpenTelemetryMetricsReporterTest {
6362

instrumentation/kafka/kafka-clients/kafka-clients-0.11/testing/src/main/java/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/KafkaClientBaseTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
import org.testcontainers.kafka.KafkaContainer;
5959
import org.testcontainers.utility.DockerImageName;
6060

61-
@SuppressWarnings("OtelInternalJavadoc")
6261
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
6362
public abstract class KafkaClientBaseTest {
6463
private static final Logger logger = LoggerFactory.getLogger(KafkaClientBaseTest.class);

instrumentation/kafka/kafka-clients/kafka-clients-0.11/testing/src/main/java/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/KafkaClientPropagationBaseTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import org.apache.kafka.clients.producer.ProducerRecord;
1414
import org.junit.jupiter.api.Test;
1515

16-
@SuppressWarnings("OtelInternalJavadoc")
1716
public abstract class KafkaClientPropagationBaseTest extends KafkaClientBaseTest {
1817
private static final boolean producerPropagationEnabled =
1918
Boolean.parseBoolean(

instrumentation/kafka/kafka-clients/kafka-clients-0.11/testing/src/main/java/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/KafkaTestUtil.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import org.apache.kafka.clients.consumer.Consumer;
1111
import org.apache.kafka.clients.consumer.ConsumerRecords;
1212

13-
@SuppressWarnings("OtelInternalJavadoc")
1413
public class KafkaTestUtil {
1514
private static final Method consumerPollDurationMethod = getConsumerPollDurationMethod();
1615

0 commit comments

Comments
 (0)