Skip to content

Commit d9b0eee

Browse files
author
Mateusz Rzeszutek
authored
Remove deprecated instrumentation-api-semconv code (#7838)
1 parent 7335347 commit d9b0eee

File tree

29 files changed

+42
-890
lines changed

29 files changed

+42
-890
lines changed

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesGetter.java

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -17,36 +17,8 @@
1717
public interface CodeAttributesGetter<REQUEST> {
1818

1919
@Nullable
20-
default Class<?> getCodeClass(REQUEST request) {
21-
return codeClass(request);
22-
}
20+
Class<?> getCodeClass(REQUEST request);
2321

24-
/**
25-
* This method is deprecated and will be removed in the subsequent release.
26-
*
27-
* @deprecated Use {@link #getCodeClass(Object)} instead.
28-
*/
29-
@Deprecated
3022
@Nullable
31-
default Class<?> codeClass(REQUEST request) {
32-
throw new UnsupportedOperationException(
33-
"This method is deprecated and will be removed in the subsequent release.");
34-
}
35-
36-
@Nullable
37-
default String getMethodName(REQUEST request) {
38-
return methodName(request);
39-
}
40-
41-
/**
42-
* This method is deprecated and will be removed in the subsequent release.
43-
*
44-
* @deprecated Use {@link #getMethodName(Object)} instead.
45-
*/
46-
@Deprecated
47-
@Nullable
48-
default String methodName(REQUEST request) {
49-
throw new UnsupportedOperationException(
50-
"This method is deprecated and will be removed in the subsequent release.");
51-
}
23+
String getMethodName(REQUEST request);
5224
}

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbClientAttributesGetter.java

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -21,36 +21,8 @@
2121
public interface DbClientAttributesGetter<REQUEST> extends DbClientCommonAttributesGetter<REQUEST> {
2222

2323
@Nullable
24-
default String getStatement(REQUEST request) {
25-
return statement(request);
26-
}
24+
String getStatement(REQUEST request);
2725

28-
/**
29-
* This method is deprecated and will be removed in the subsequent release.
30-
*
31-
* @deprecated Use {@link #getStatement(Object)} instead.
32-
*/
33-
@Deprecated
3426
@Nullable
35-
default String statement(REQUEST request) {
36-
throw new UnsupportedOperationException(
37-
"This method is deprecated and will be removed in the subsequent release.");
38-
}
39-
40-
@Nullable
41-
default String getOperation(REQUEST request) {
42-
return operation(request);
43-
}
44-
45-
/**
46-
* This method is deprecated and will be removed in the subsequent release.
47-
*
48-
* @deprecated Use {@link #getOperation(Object)} instead.
49-
*/
50-
@Deprecated
51-
@Nullable
52-
default String operation(REQUEST request) {
53-
throw new UnsupportedOperationException(
54-
"This method is deprecated and will be removed in the subsequent release.");
55-
}
27+
String getOperation(REQUEST request);
5628
}

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbClientCommonAttributesGetter.java

Lines changed: 4 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -11,70 +11,14 @@
1111
public interface DbClientCommonAttributesGetter<REQUEST> {
1212

1313
@Nullable
14-
default String getSystem(REQUEST request) {
15-
return system(request);
16-
}
14+
String getSystem(REQUEST request);
1715

18-
/**
19-
* This method is deprecated and will be removed in the subsequent release.
20-
*
21-
* @deprecated Use {@link #getSystem(Object)} instead.
22-
*/
23-
@Deprecated
2416
@Nullable
25-
default String system(REQUEST request) {
26-
throw new UnsupportedOperationException(
27-
"This method is deprecated and will be removed in the subsequent release.");
28-
}
17+
String getUser(REQUEST request);
2918

3019
@Nullable
31-
default String getUser(REQUEST request) {
32-
return user(request);
33-
}
20+
String getName(REQUEST request);
3421

35-
/**
36-
* This method is deprecated and will be removed in the subsequent release.
37-
*
38-
* @deprecated Use {@link #getUser(Object)} instead.
39-
*/
40-
@Deprecated
4122
@Nullable
42-
default String user(REQUEST request) {
43-
throw new UnsupportedOperationException(
44-
"This method is deprecated and will be removed in the subsequent release.");
45-
}
46-
47-
@Nullable
48-
default String getName(REQUEST request) {
49-
return name(request);
50-
}
51-
52-
/**
53-
* This method is deprecated and will be removed in the subsequent release.
54-
*
55-
* @deprecated Use {@link #getName(Object)} instead.
56-
*/
57-
@Deprecated
58-
@Nullable
59-
default String name(REQUEST request) {
60-
throw new UnsupportedOperationException(
61-
"This method is deprecated and will be removed in the subsequent release.");
62-
}
63-
64-
@Nullable
65-
default String getConnectionString(REQUEST request) {
66-
return connectionString(request);
67-
}
68-
69-
/**
70-
* This method is deprecated and will be removed in the subsequent release.
71-
*
72-
* @deprecated Use {@link #getConnectionString(Object)} instead.
73-
*/
74-
@Deprecated
75-
@Nullable
76-
default String connectionString(REQUEST request) {
77-
throw new UnsupportedOperationException(
78-
"This method is deprecated and will be removed in the subsequent release.");
79-
}
23+
String getConnectionString(REQUEST request);
8024
}

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlClientAttributesGetter.java

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,5 @@ public interface SqlClientAttributesGetter<REQUEST>
2626
* SqlClientAttributesExtractor} before being set as span attribute.
2727
*/
2828
@Nullable
29-
default String getRawStatement(REQUEST request) {
30-
return rawStatement(request);
31-
}
32-
33-
/**
34-
* Get the raw SQL statement. The value returned by this method is later sanitized by the {@link
35-
* SqlClientAttributesExtractor} before being set as span attribute.
36-
*
37-
* <p>This method is deprecated and will be removed in the subsequent release.
38-
*
39-
* @deprecated Use {@link #getRawStatement(Object)} instead.
40-
*/
41-
@Deprecated
42-
@Nullable
43-
default String rawStatement(REQUEST request) {
44-
throw new UnsupportedOperationException(
45-
"This method is deprecated and will be removed in the subsequent release.");
46-
}
29+
String getRawStatement(REQUEST request);
4730
}

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpClientAttributesExtractor.java

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -32,37 +32,13 @@ public final class HttpClientAttributesExtractor<REQUEST, RESPONSE>
3232
REQUEST, RESPONSE, HttpClientAttributesGetter<REQUEST, RESPONSE>>
3333
implements SpanKeyProvider {
3434

35-
/**
36-
* Creates the HTTP client attributes extractor with default configuration.
37-
*
38-
* @deprecated Use {@link #create(HttpClientAttributesGetter, NetClientAttributesGetter)} instead.
39-
*/
40-
@Deprecated
41-
public static <REQUEST, RESPONSE> AttributesExtractor<REQUEST, RESPONSE> create(
42-
HttpClientAttributesGetter<REQUEST, RESPONSE> getter) {
43-
return builder(getter).build();
44-
}
45-
4635
/** Creates the HTTP client attributes extractor with default configuration. */
4736
public static <REQUEST, RESPONSE> AttributesExtractor<REQUEST, RESPONSE> create(
4837
HttpClientAttributesGetter<REQUEST, RESPONSE> httpAttributesGetter,
4938
NetClientAttributesGetter<REQUEST, RESPONSE> netAttributesGetter) {
5039
return builder(httpAttributesGetter, netAttributesGetter).build();
5140
}
5241

53-
/**
54-
* Returns a new {@link HttpClientAttributesExtractorBuilder} that can be used to configure the
55-
* HTTP client attributes extractor.
56-
*
57-
* @deprecated Use {@link #builder(HttpClientAttributesGetter, NetClientAttributesGetter)}
58-
* instead.
59-
*/
60-
@Deprecated
61-
public static <REQUEST, RESPONSE> HttpClientAttributesExtractorBuilder<REQUEST, RESPONSE> builder(
62-
HttpClientAttributesGetter<REQUEST, RESPONSE> httpAttributesGetter) {
63-
return builder(httpAttributesGetter, new NoopNetClientAttributesGetter<>());
64-
}
65-
6642
/**
6743
* Returns a new {@link HttpClientAttributesExtractorBuilder} that can be used to configure the
6844
* HTTP client attributes extractor.
@@ -175,26 +151,4 @@ public void onEnd(
175151
public SpanKey internalGetSpanKey() {
176152
return SpanKey.HTTP_CLIENT;
177153
}
178-
179-
private static final class NoopNetClientAttributesGetter<REQUEST, RESPONSE>
180-
implements NetClientAttributesGetter<REQUEST, RESPONSE> {
181-
182-
@Nullable
183-
@Override
184-
public String getTransport(REQUEST request, @Nullable RESPONSE response) {
185-
return null;
186-
}
187-
188-
@Nullable
189-
@Override
190-
public String getPeerName(REQUEST request) {
191-
return null;
192-
}
193-
194-
@Nullable
195-
@Override
196-
public Integer getPeerPort(REQUEST request) {
197-
return null;
198-
}
199-
}
200154
}

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpClientAttributesGetter.java

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,7 @@ public interface HttpClientAttributesGetter<REQUEST, RESPONSE>
2222
// Attributes that always exist in a request
2323

2424
@Nullable
25-
default String getUrl(REQUEST request) {
26-
return url(request);
27-
}
28-
29-
/**
30-
* This method is deprecated and will be removed in the subsequent release.
31-
*
32-
* @deprecated Use {@link #getUrl(Object)} instead.
33-
*/
34-
@Deprecated
35-
@Nullable
36-
default String url(REQUEST request) {
37-
throw new UnsupportedOperationException(
38-
"This method is deprecated and will be removed in the subsequent release.");
39-
}
25+
String getUrl(REQUEST request);
4026

4127
// Attributes which are not always available when the request is ready.
4228

@@ -47,24 +33,5 @@ default String url(REQUEST request) {
4733
* {@code response} is {@code null} or not.
4834
*/
4935
@Nullable
50-
default String getFlavor(REQUEST request, @Nullable RESPONSE response) {
51-
return flavor(request, response);
52-
}
53-
54-
/**
55-
* Extracts the {@code http.flavor} span attribute.
56-
*
57-
* <p>This is called from {@link Instrumenter#end(Context, Object, Object, Throwable)}, whether
58-
* {@code response} is {@code null} or not.
59-
*
60-
* <p>This method is deprecated and will be removed in the subsequent release.
61-
*
62-
* @deprecated Use {@link #getFlavor(Object, Object)}.
63-
*/
64-
@Deprecated
65-
@Nullable
66-
default String flavor(REQUEST request, @Nullable RESPONSE response) {
67-
throw new UnsupportedOperationException(
68-
"This method is deprecated and will be removed in the subsequent release.");
69-
}
36+
String getFlavor(REQUEST request, @Nullable RESPONSE response);
7037
}

instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpCommonAttributesGetter.java

Lines changed: 4 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,7 @@ public interface HttpCommonAttributesGetter<REQUEST, RESPONSE> {
1616
// Attributes that always exist in a request
1717

1818
@Nullable
19-
default String getMethod(REQUEST request) {
20-
return method(request);
21-
}
22-
23-
/**
24-
* This method is deprecated and will be removed in the subsequent release.
25-
*
26-
* @deprecated Use {@link #getMethod(Object)} instead.
27-
*/
28-
@Deprecated
29-
@Nullable
30-
default String method(REQUEST request) {
31-
throw new UnsupportedOperationException(
32-
"This method is deprecated and will be removed in the subsequent release.");
33-
}
19+
String getMethod(REQUEST request);
3420

3521
/**
3622
* Extracts all values of header named {@code name} from the request, or an empty list if there
@@ -39,26 +25,7 @@ default String method(REQUEST request) {
3925
* <p>Implementations of this method <b>must not</b> return a null value; an empty list should be
4026
* returned instead.
4127
*/
42-
default List<String> getRequestHeader(REQUEST request, String name) {
43-
return requestHeader(request, name);
44-
}
45-
46-
/**
47-
* Extracts all values of header named {@code name} from the request, or an empty list if there
48-
* were none.
49-
*
50-
* <p>Implementations of this method <b>must not</b> return a null value; an empty list should be
51-
* returned instead.
52-
*
53-
* <p>This method is deprecated and will be removed in the subsequent release.
54-
*
55-
* @deprecated Use {@link #getRequestHeader(Object, String)} instead.
56-
*/
57-
@Deprecated
58-
default List<String> requestHeader(REQUEST request, String name) {
59-
throw new UnsupportedOperationException(
60-
"This method is deprecated and will be removed in the subsequent release.");
61-
}
28+
List<String> getRequestHeader(REQUEST request, String name);
6229

6330
// Attributes which are not always available when the request is ready.
6431

@@ -69,26 +36,7 @@ default List<String> requestHeader(REQUEST request, String name) {
6936
* {@code response} is non-{@code null}.
7037
*/
7138
@Nullable
72-
default Integer getStatusCode(REQUEST request, RESPONSE response, @Nullable Throwable error) {
73-
return statusCode(request, response, error);
74-
}
75-
76-
/**
77-
* Extracts the {@code http.status_code} span attribute.
78-
*
79-
* <p>This is called from {@link Instrumenter#end(Context, Object, Object, Throwable)}, only when
80-
* {@code response} is non-{@code null}.
81-
*
82-
* <p>This method is deprecated and will be removed in the subsequent release.
83-
*
84-
* @deprecated Use {@link #getStatusCode(Object, Object, Throwable)} instead.
85-
*/
86-
@Deprecated
87-
@Nullable
88-
default Integer statusCode(REQUEST request, RESPONSE response, @Nullable Throwable error) {
89-
throw new UnsupportedOperationException(
90-
"This method is deprecated and will be removed in the subsequent release.");
91-
}
39+
Integer getStatusCode(REQUEST request, RESPONSE response, @Nullable Throwable error);
9240

9341
/**
9442
* Extracts all values of header named {@code name} from the response, or an empty list if there
@@ -100,27 +48,5 @@ default Integer statusCode(REQUEST request, RESPONSE response, @Nullable Throwab
10048
* <p>Implementations of this method <b>must not</b> return a null value; an empty list should be
10149
* returned instead.
10250
*/
103-
default List<String> getResponseHeader(REQUEST request, RESPONSE response, String name) {
104-
return responseHeader(request, response, name);
105-
}
106-
107-
/**
108-
* Extracts all values of header named {@code name} from the response, or an empty list if there
109-
* were none.
110-
*
111-
* <p>This is called from {@link Instrumenter#end(Context, Object, Object, Throwable)}, only when
112-
* {@code response} is non-{@code null}.
113-
*
114-
* <p>Implementations of this method <b>must not</b> return a null value; an empty list should be
115-
* returned instead.
116-
*
117-
* <p>This method is deprecated and will be removed in the subsequent release.
118-
*
119-
* @deprecated Use {@link #getResponseHeader(Object, Object, String)} instead.
120-
*/
121-
@Deprecated
122-
default List<String> responseHeader(REQUEST request, RESPONSE response, String name) {
123-
throw new UnsupportedOperationException(
124-
"This method is deprecated and will be removed in the subsequent release.");
125-
}
51+
List<String> getResponseHeader(REQUEST request, RESPONSE response, String name);
12652
}

0 commit comments

Comments
 (0)