Skip to content

Commit da46f57

Browse files
committed
Support extensions for spanNameExtractor
1 parent 7ed6e43 commit da46f57

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/InstrumentationCustomizer.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ default OperationMetrics getOperationMetrics() {
5151
* @param <RESPONSE> the type of response object used by the instrumented library
5252
* @return an attributes extractor instance, or null if not applicable
5353
*/
54-
default <REQUEST, RESPONSE>
55-
AttributesExtractor<? super REQUEST, ? super RESPONSE> getAttributesExtractor() {
54+
default <REQUEST, RESPONSE> AttributesExtractor<REQUEST, RESPONSE> getAttributesExtractor() {
5655
return null;
5756
}
5857

@@ -63,7 +62,7 @@ default OperationMetrics getOperationMetrics() {
6362
* @param <REQUEST> the type of request object used by the instrumented library
6463
* @return a context customizer instance, or null if not applicable
6564
*/
66-
default <REQUEST> ContextCustomizer<? super REQUEST> getContextCustomizer() {
65+
default <REQUEST> ContextCustomizer<REQUEST> getContextCustomizer() {
6766
return null;
6867
}
6968

@@ -74,7 +73,7 @@ default <REQUEST> ContextCustomizer<? super REQUEST> getContextCustomizer() {
7473
* @param <REQUEST> the type of request object used by the instrumented library
7574
* @return a customized {@link SpanNameExtractor}, or null if not applicable
7675
*/
77-
default <REQUEST> SpanNameExtractor<? super REQUEST> getSpanNameExtractor() {
76+
default <REQUEST> SpanNameExtractor<REQUEST> getSpanNameExtractor() {
7877
return null;
7978
}
8079
}

instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/internal/InstrumentationCustomizerTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,18 @@ public OperationMetrics getOperationMetrics() {
4646

4747
@Override
4848
public <REQUEST, RESPONSE>
49-
AttributesExtractor<? super REQUEST, ? super RESPONSE> getAttributesExtractor() {
50-
return (AttributesExtractor<? super REQUEST, ? super RESPONSE>) attributesExtractor;
49+
AttributesExtractor<REQUEST, RESPONSE> getAttributesExtractor() {
50+
return (AttributesExtractor<REQUEST, RESPONSE>) attributesExtractor;
5151
}
5252

5353
@Override
54-
public <REQUEST> ContextCustomizer<? super REQUEST> getContextCustomizer() {
55-
return (ContextCustomizer<? super REQUEST>) contextCustomizer;
54+
public <REQUEST> ContextCustomizer<REQUEST> getContextCustomizer() {
55+
return (ContextCustomizer<REQUEST>) contextCustomizer;
5656
}
5757

5858
@Override
59-
public <REQUEST> SpanNameExtractor<? super REQUEST> getSpanNameExtractor() {
60-
return (SpanNameExtractor<? super REQUEST>) spanNameExtractor;
59+
public <REQUEST> SpanNameExtractor<REQUEST> getSpanNameExtractor() {
60+
return (SpanNameExtractor<REQUEST>) spanNameExtractor;
6161
}
6262
};
6363
}

0 commit comments

Comments
 (0)