pr review

Author: zeitlinger

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java

@@ -172,7 +172,7 @@ private static void installBytebuddyAgent(
 
     setBootstrapPackages(sdkConfig, extensionClassLoader);
     ConfiguredResourceAttributesHolder.initialize(
-        SdkAutoconfigureAccess.getResourceAttributes(autoConfiguredSdk));
+        SdkAutoconfigureAccess.getResource(autoConfiguredSdk).getAttributes());
 
     for (BeforeAgentListener agentListener :
         loadOrdered(BeforeAgentListener.class, extensionClassLoader)) {

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/OpenTelemetryInstaller.java

@@ -14,7 +14,6 @@
 import io.opentelemetry.sdk.autoconfigure.SdkAutoconfigureAccess;
 import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
 import io.opentelemetry.sdk.common.CompletableResultCode;
-import io.opentelemetry.sdk.resources.Resource;
 import java.util.Arrays;
 
 public final class OpenTelemetryInstaller {
@@ -44,13 +43,10 @@ public static AutoConfiguredOpenTelemetrySdk installOpenTelemetrySdk(
       // This allows most instrumentations to be unaware of which configuration style is used.
       return SdkAutoconfigureAccess.create(
           sdk,
-          // the Resource from the original instance is also the default Resource,
-          // so this is functionally equivalent
-          Resource.getDefault(),
+          SdkAutoconfigureAccess.getResource(autoConfiguredSdk),
           new DeclarativeConfigPropertiesBridgeBuilder()
-              .addMapping(
-                  "otel.instrumentation.common.default-enabled", "common.default.enabled")
-                .addMapping("otel.javaagent", "agent")
+              .addMapping("otel.instrumentation.common.default-enabled", "common.default.enabled")
+              .addMapping("otel.javaagent", "agent")
               // these properties are used to initialize the SDK before the configuration file
               // is loaded for consistency, we pass them to the bridge, so that they can be read
               // later with the same value from the {@link DeclarativeConfigPropertiesBridge}

javaagent-tooling/src/main/java/io/opentelemetry/sdk/autoconfigure/SdkAutoconfigureAccess.java

@@ -5,16 +5,15 @@
 
 package io.opentelemetry.sdk.autoconfigure;
 
-import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.sdk.OpenTelemetrySdk;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import io.opentelemetry.sdk.resources.Resource;
 
 public final class SdkAutoconfigureAccess {
   private SdkAutoconfigureAccess() {}
 
-  public static Attributes getResourceAttributes(AutoConfiguredOpenTelemetrySdk sdk) {
-    return sdk.getResource().getAttributes();
+  public static Resource getResource(AutoConfiguredOpenTelemetrySdk sdk) {
+    return sdk.getResource();
   }
 
   public static AutoConfiguredOpenTelemetrySdk create(