Skip to content

Commit db7c8a3

Browse files
committed
fix and simplify jetty test
1 parent 531f836 commit db7c8a3

File tree

1 file changed

+8
-14
lines changed
  • instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules

1 file changed

+8
-14
lines changed
Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@
1919
import org.junit.jupiter.params.provider.ValueSource;
2020
import org.testcontainers.containers.GenericContainer;
2121
import org.testcontainers.containers.wait.strategy.Wait;
22-
import org.testcontainers.images.builder.ImageFromDockerfile;
2322

24-
public class JettyIntegrationTest extends TargetSystemTest {
23+
public class JettyTest extends TargetSystemTest {
2524

2625
private static final int JETTY_PORT = 8080;
2726

@@ -48,25 +47,20 @@ void testCollectedMetrics(int jettyMajorVersion) {
4847
// with older versions deployment and session management are available by default
4948
jettyModules.add("stats");
5049
}
51-
String addModulesArg = "--add-to-startd=" + String.join(",", jettyModules);
50+
String moduleArg = "--module=" + String.join(",", jettyModules);
5251

5352
GenericContainer<?> container =
54-
new GenericContainer<>(
55-
new ImageFromDockerfile()
56-
.withDockerfileFromBuilder(
57-
builder ->
58-
builder
59-
.from("jetty:" + jettyMajorVersion)
60-
.run("java", "-jar", "/usr/local/jetty/start.jar", addModulesArg)
61-
.run("mkdir -p /var/lib/jetty/webapps/ROOT/")
62-
.run("touch /var/lib/jetty/webapps/ROOT/index.html")
63-
.build()))
53+
new GenericContainer<>("jetty:" + jettyMajorVersion)
54+
.withCommand(moduleArg)
6455
.withEnv("JAVA_OPTIONS", String.join(" ", jvmArgs))
6556
.withStartupTimeout(Duration.ofMinutes(2))
6657
.withExposedPorts(JETTY_PORT)
6758
.waitingFor(Wait.forListeningPorts(JETTY_PORT));
6859

69-
copyFilesToTarget(container, yamlFiles);
60+
copyAgentToTarget(container);
61+
copyYamlFilesToTarget(container, yamlFiles);
62+
// Deploy example web application for session-related metrics
63+
copyTestWebAppToTarget(container, "/var/lib/jetty/webapps/ROOT.war");
7064

7165
startTarget(container);
7266

0 commit comments

Comments
 (0)