jaxrs-1.0

Author: SylvainJuge

instrumentation/jaxrs/jaxrs-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v1_0/JaxrsAnnotationsInstrumentation.java

@@ -26,6 +26,7 @@
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import java.lang.reflect.Method;
+import javax.annotation.Nullable;
 import javax.ws.rs.Path;
 import net.bytebuddy.asm.Advice;
 import net.bytebuddy.description.type.TypeDescription;
@@ -67,52 +68,62 @@ public void transform(TypeTransformer transformer) {
   @SuppressWarnings("unused")
   public static class JaxRsAnnotationsAdvice {
 
-    @Advice.OnMethodEnter(suppress = Throwable.class)
-    public static void nameSpan(
-        @Advice.This Object target,
-        @Advice.Origin Method method,
-        @Advice.Local("otelCallDepth") CallDepth callDepth,
-        @Advice.Local("otelHandlerData") HandlerData handlerData,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
-      callDepth = CallDepth.forClass(Path.class);
-      if (callDepth.getAndIncrement() > 0) {
-        return;
+    public static class AdviceScope {
+      private HandlerData handlerData;
+      private final CallDepth callDepth;
+      private Context context;
+      private Scope scope;
+
+      public AdviceScope(CallDepth callDepth) {
+        this.callDepth = callDepth;
       }
 
-      Context parentContext = Java8BytecodeBridge.currentContext();
-      handlerData = new HandlerData(target.getClass(), method);
+      public AdviceScope enter(Class<?> type, Method method) {
+        if (callDepth.getAndIncrement() > 0) {
+          return this;
+        }
+
+        Context parentContext = Java8BytecodeBridge.currentContext();
+        handlerData = new HandlerData(type, method);
+
+        HttpServerRoute.update(
+            parentContext,
+            HttpServerRouteSource.CONTROLLER,
+            JaxrsServerSpanNaming.SERVER_SPAN_NAME,
+            handlerData);
+
+        if (!instrumenter().shouldStart(parentContext, handlerData)) {
+          return this;
+        }
+
+        context = instrumenter().start(parentContext, handlerData);
+        scope = context.makeCurrent();
+        return this;
+      }
 
-      HttpServerRoute.update(
-          parentContext,
-          HttpServerRouteSource.CONTROLLER,
-          JaxrsServerSpanNaming.SERVER_SPAN_NAME,
-          handlerData);
+      public void exit(@Nullable Throwable throwable) {
+        if (callDepth.decrementAndGet() > 0) {
+          return;
+        }
 
-      if (!instrumenter().shouldStart(parentContext, handlerData)) {
-        return;
+        if (scope == null) {
+          return;
+        }
+        scope.close();
+        instrumenter().end(context, handlerData, null, throwable);
       }
+    }
 
-      context = instrumenter().start(parentContext, handlerData);
-      scope = context.makeCurrent();
+    @Advice.OnMethodEnter(suppress = Throwable.class)
+    public static AdviceScope nameSpan(@Advice.This Object target, @Advice.Origin Method method) {
+      AdviceScope adviceScope = new AdviceScope(CallDepth.forClass(Path.class));
+      return adviceScope.enter(target.getClass(), method);
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
     public static void stopSpan(
-        @Advice.Thrown Throwable throwable,
-        @Advice.Local("otelCallDepth") CallDepth callDepth,
-        @Advice.Local("otelHandlerData") HandlerData handlerData,
-        @Advice.Local("otelContext") Context context,
-        @Advice.Local("otelScope") Scope scope) {
-      if (callDepth.decrementAndGet() > 0) {
-        return;
-      }
-
-      if (scope == null) {
-        return;
-      }
-      scope.close();
-      instrumenter().end(context, handlerData, null, throwable);
+        @Advice.Thrown @Nullable Throwable throwable, @Advice.Enter AdviceScope adviceScope) {
+      adviceScope.exit(throwable);
     }
   }
 }

instrumentation/jaxrs/jaxrs-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v1_0/JaxrsInstrumentationModule.java

@@ -13,12 +13,14 @@
 import io.opentelemetry.javaagent.bootstrap.internal.ExperimentalConfig;
 import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
+import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import java.util.List;
 import net.bytebuddy.matcher.ElementMatcher;
 
 @AutoService(InstrumentationModule.class)
-public class JaxrsInstrumentationModule extends InstrumentationModule {
+public class JaxrsInstrumentationModule extends InstrumentationModule
+    implements ExperimentalInstrumentationModule {
   public JaxrsInstrumentationModule() {
     super("jaxrs", "jaxrs-1.0");
   }
@@ -41,4 +43,9 @@ public boolean defaultEnabled(ConfigProperties config) {
     // This instrumentation uses complex type matcher, disabling it can improve startup performance.
     return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
   }
+
+  @Override
+  public boolean isIndyReady() {
+    return true;
+  }
 }