add tests on default inbox monitoring

Author: AlixBa

instrumentation/nats/nats-2.17/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/nats/v2_17/NatsInstrumentationRequestTest.java

@@ -19,9 +19,4 @@ class NatsInstrumentationRequestTest extends AbstractNatsInstrumentationRequestT
   protected InstrumentationExtension testing() {
     return testing;
   }
-
-  @Override
-  protected boolean isInboxMonitored() {
-    return true;
-  }
 }

instrumentation/nats/nats-2.17/library/src/test/java/io/opentelemetry/instrumentation/nats/v2_17/NatsInstrumentationRequestTest.java

@@ -5,8 +5,11 @@
 
 package io.opentelemetry.instrumentation.nats.v2_17;
 
+import io.nats.client.Nats;
+import io.nats.client.Options;
 import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
 import io.opentelemetry.instrumentation.testing.junit.LibraryInstrumentationExtension;
+import java.io.IOException;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
@@ -21,15 +24,11 @@ protected InstrumentationExtension testing() {
   }
 
   @BeforeAll
-  static void beforeAll() {
-    connection = NatsTelemetry.create(testing.getOpenTelemetry()).wrap(connection);
-  }
-
-  @Override
-  protected boolean isInboxMonitored() {
-    // in the library instrumentation, as we're proxying Connection,
-    // we can not properly instrument the Dispatcher and the MessageHandler
-    // created for every `request` on the _INBOX.* subjects
-    return false;
+  static void beforeAll() throws IOException, InterruptedException {
+    NatsTelemetry telemetry = NatsTelemetry.create(testing.getOpenTelemetry());
+    connection =
+        telemetry.wrap(
+            Nats.connect(
+                telemetry.wrap(Options.builder().server(connection.getConnectedUrl())).build()));
   }
 }

instrumentation/nats/nats-2.17/testing/src/main/java/io/opentelemetry/instrumentation/nats/v2_17/AbstractNatsInstrumentationRequestTest.java

@@ -29,8 +29,6 @@
 public abstract class AbstractNatsInstrumentationRequestTest
     extends AbstractNatsInstrumentationTest {
 
-  protected abstract boolean isInboxMonitored();
-
   private int clientId;
   private Subscription subscription;
 
@@ -307,10 +305,6 @@ private void assertPublishReceiveSpansSameTrace() {
                                   .hasAttributesSatisfyingExactly(
                                       messagingAttributes("process", "_INBOX.", clientId))));
 
-              if (!isInboxMonitored()) {
-                asserts.remove(asserts.size() - 1);
-              }
-
               trace.hasSpansSatisfyingExactly(asserts);
             });
   }