Remove misspell workflow (#15353)

Author: trask

.github/workflows/build-daily-no-build-cache.yml

@@ -29,8 +29,8 @@ jobs:
   # muzzle is not included here because it doesn't use gradle cache anyway and so is already covered
   # by the normal daily build
 
-  # link-check and misspell-check are not included here because they don't use gradle cache
-  # anyway and so are already covered by the normal daily build
+  # link-check is not included here because it doesn't use gradle cache anyway and so is already
+  # covered by the normal daily build
 
   workflow-notification:
     permissions:

.github/workflows/build-daily.yml

@@ -34,9 +34,6 @@ jobs:
   markdown-lint-check:
     uses: ./.github/workflows/reusable-markdown-lint-check.yml
 
-  misspell-check:
-    uses: ./.github/workflows/reusable-misspell-check.yml
-
   workflow-notification:
     permissions:
       contents: read
@@ -46,7 +43,6 @@ jobs:
       - test-latest-deps
       - muzzle
       - link-check
-      - misspell-check
     if: always()
     uses: ./.github/workflows/reusable-workflow-notification.yml
     with:
@@ -55,6 +51,5 @@ jobs:
           needs.common.result == 'success' &&
           needs.test-latest-deps.result == 'success' &&
           needs.muzzle.result == 'success' &&
-          needs.link-check.result == 'success' &&
-          needs.misspell-check.result == 'success'
+          needs.link-check.result == 'success'
         }}

.github/workflows/build-pull-request.yml

@@ -53,9 +53,6 @@ jobs:
   markdown-lint-check:
     uses: ./.github/workflows/reusable-markdown-lint-check.yml
 
-  misspell-check:
-    uses: ./.github/workflows/reusable-misspell-check.yml
-
   required-status-check:
     # test-latest-deps is not included in the required status checks
     # because any time a new library version is released to maven central
@@ -71,7 +68,6 @@ jobs:
       - muzzle
       - shell-script-check
       - markdown-lint-check
-      - misspell-check
     runs-on: ubuntu-latest
     if: always()
     steps:
@@ -82,8 +78,7 @@ jobs:
             (
               needs.muzzle.result != 'success' ||
               needs.shell-script-check.result != 'success' ||
-              needs.markdown-lint-check.result != 'success' ||
-              needs.misspell-check.result != 'success'
+              needs.markdown-lint-check.result != 'success'
             )
           )
         run: exit 1 # fail

.github/workflows/build.yml

@@ -51,16 +51,9 @@ jobs:
     if: "!startsWith(github.ref_name, 'release/')"
     uses: ./.github/workflows/reusable-markdown-lint-check.yml
 
-  misspell-check:
-    # release branches are excluded to avoid unnecessary maintenance if new misspellings are added
-    # to the misspell dictionary
-    if: "!startsWith(github.ref_name, 'release/')"
-    uses: ./.github/workflows/reusable-misspell-check.yml
-
   publish-snapshots:
     needs:
-      # intentionally not blocking snapshot publishing on test-latest-deps, muzzle,
-      # link-check, or misspell-check
+      # intentionally not blocking snapshot publishing on test-latest-deps, muzzle, or link-check
       - common
     runs-on: ubuntu-latest
     # skipping release branches because the versions in those branches are not snapshots