error.type and db.response.status_code all dbs

Author: zeitlinger

instrumentation/clickhouse-client-0.5/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/clickhouse/ClickHouseClientTest.java

@@ -7,10 +7,12 @@
 
 import static io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil.maybeStable;
 import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
+import static io.opentelemetry.semconv.ErrorAttributes.ERROR_TYPE;
 import static io.opentelemetry.semconv.ServerAttributes.SERVER_ADDRESS;
 import static io.opentelemetry.semconv.ServerAttributes.SERVER_PORT;
 import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_NAME;
 import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_OPERATION;
+import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_RESPONSE_STATUS_CODE;
 import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_STATEMENT;
 import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_SYSTEM;
 import static java.util.Arrays.asList;
@@ -34,6 +36,7 @@
 import io.opentelemetry.sdk.trace.data.StatusData;
 import io.opentelemetry.semconv.incubating.DbIncubatingAttributes;
 import java.time.Instant;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
 import org.junit.jupiter.api.AfterAll;
@@ -196,6 +199,10 @@ void testExecuteAndWaitThrowsException() {
 
     assertThat(thrown).isInstanceOf(ClickHouseException.class);
 
+    List<AttributeAssertion> assertions =
+        new ArrayList<>(attributeAssertions("select * from non_existent_table", "SELECT"));
+    assertions.add(equalTo(DB_RESPONSE_STATUS_CODE, "60"));
+    assertions.add(equalTo(ERROR_TYPE, "com.clickhouse.client.ClickHouseException"));
     testing.waitAndAssertTraces(
         trace ->
             trace.hasSpansSatisfyingExactly(
@@ -204,8 +211,7 @@ void testExecuteAndWaitThrowsException() {
                         .hasKind(SpanKind.CLIENT)
                         .hasStatus(StatusData.error())
                         .hasException(thrown)
-                        .hasAttributesSatisfyingExactly(
-                            attributeAssertions("select * from non_existent_table", "SELECT"))));
+                        .hasAttributesSatisfyingExactly(assertions)));
   }
 
   @Test

instrumentation/couchbase/couchbase-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/couchbase/v2_0/CouchbaseAttributesGetter.java

@@ -55,6 +55,7 @@ public String getDbOperationName(CouchbaseRequestInfo couchbaseRequest) {
   @Override
   public String getResponseStatusFromException(Throwable throwable) {
     if (throwable instanceof CouchbaseException) {
+      // todo
       //      ResponseStatusDetails details = ((CouchbaseException) throwable).details();
       // in newer versions of the SDK, this is available as a method on the exception
       // check if it's available and contains the status

instrumentation/spymemcached-2.12/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spymemcached/SpymemcachedTest.java

@@ -10,6 +10,7 @@
 import static io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil.maybeStable;
 import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
 import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.satisfies;
+import static io.opentelemetry.semconv.ErrorAttributes.ERROR_TYPE;
 import static io.opentelemetry.semconv.ExceptionAttributes.EXCEPTION_MESSAGE;
 import static io.opentelemetry.semconv.ExceptionAttributes.EXCEPTION_STACKTRACE;
 import static io.opentelemetry.semconv.ExceptionAttributes.EXCEPTION_TYPE;
@@ -882,7 +883,10 @@ void decrException() {
                             equalTo(
                                 maybeStable(DB_SYSTEM),
                                 DbIncubatingAttributes.DbSystemIncubatingValues.MEMCACHED),
-                            equalTo(maybeStable(DB_OPERATION), "decr"))));
+                            equalTo(maybeStable(DB_OPERATION), "decr"),
+                            equalTo(
+                                ERROR_TYPE,
+                                "net.spy.memcached.internal.CheckedOperationTimeoutException"))));
   }
 
   @Test

instrumentation/vertx/vertx-sql-client-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxSqlClientAttributesGetter.java

@@ -48,6 +48,7 @@ public Collection<String> getRawQueryTexts(VertxSqlClientRequest request) {
   @Nullable
   @Override
   public String getResponseStatusFromException(Throwable throwable) {
+    // todo
     // 4.4.2 has this
     //    if (throwable instanceof io.vertx.sqlclient.DatabaseException) {
     //