Skip to content

Commit e4d6dbb

Browse files
committed
fix jetty 12
1 parent a51d69b commit e4d6dbb

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

instrumentation/jetty/jetty-11.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jetty/v11_0/Jetty11HandlerAdvice.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,5 @@ public static void stopSpan(
7979
if (adviceScope != null) {
8080
adviceScope.end(throwable, request, response);
8181
}
82-
8382
}
84-
8583
}

instrumentation/jetty/jetty-12.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jetty/v12_0/Jetty12ServerInstrumentation.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
import io.opentelemetry.context.Context;
1414
import io.opentelemetry.context.Scope;
15-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1615
import io.opentelemetry.javaagent.bootstrap.http.HttpServerResponseCustomizerHolder;
1716
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1817
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
@@ -55,7 +54,7 @@ private AdviceScope(Context context, Scope scope) {
5554

5655
@Nullable
5756
public static AdviceScope start(Object source, Request request, Response response) {
58-
Context parentContext = Java8BytecodeBridge.currentContext();
57+
Context parentContext = Context.current();
5958
if (!helper().shouldStart(parentContext, request)) {
6059
return null;
6160
}
@@ -67,15 +66,15 @@ public static AdviceScope start(Object source, Request request, Response respons
6766
}
6867

6968
public void end(Request request, Response response, @Nullable Throwable throwable) {
70-
if (scope != null) {
71-
scope.close();
69+
scope.close();
70+
if (throwable != null) {
7271
helper().end(context, request, response, throwable);
7372
}
7473
}
7574
}
7675

77-
@Advice.OnMethodEnter(suppress = Throwable.class)
7876
@Nullable
77+
@Advice.OnMethodEnter(suppress = Throwable.class)
7978
public static AdviceScope onEnter(
8079
@Advice.This Object source,
8180
@Advice.Argument(0) Request request,

0 commit comments

Comments
 (0)