Skip to content

Commit e599182

Browse files
committed
switch back to messaging.client_id, it is renamed to messaging.client.id in semconv
1 parent 043c857 commit e599182

File tree

1 file changed

+5
-1
lines changed
  • instrumentation/nats/nats-2.17/testing/src/main/java/io/opentelemetry/instrumentation/nats/v2_17

1 file changed

+5
-1
lines changed

instrumentation/nats/nats-2.17/testing/src/main/java/io/opentelemetry/instrumentation/nats/v2_17/NatsTestHelper.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55

66
package io.opentelemetry.instrumentation.nats.v2_17;
77

8+
import static io.opentelemetry.api.common.AttributeKey.stringKey;
89
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
9-
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_CLIENT_ID;
1010
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_DESTINATION_NAME;
1111
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_MESSAGE_BODY_SIZE;
1212
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_OPERATION;
@@ -15,12 +15,16 @@
1515

1616
import io.nats.client.Message;
1717
import io.nats.client.Subscription;
18+
import io.opentelemetry.api.common.AttributeKey;
1819
import io.opentelemetry.sdk.testing.assertj.AttributeAssertion;
1920
import java.time.Duration;
2021

2122
@SuppressWarnings("deprecation") // using deprecated semconv
2223
public class NatsTestHelper {
2324

25+
// copied from MessagingIncubatingAttributes
26+
private static final AttributeKey<String> MESSAGING_CLIENT_ID = stringKey("messaging.client_id");
27+
2428
public static AttributeAssertion[] messagingAttributes(
2529
String operation, String subject, int clientId, AttributeAssertion other) {
2630
return messagingAttributes(operation, subject, clientId, new AttributeAssertion[] {other});

0 commit comments

Comments
 (0)