Apply suggestions from code review

Co-authored-by: Jay DeLuca <[email protected]>

Author: ghareeb-falazi

instrumentation/iceberg-1.8/README.md

@@ -28,7 +28,7 @@ implementation("io.opentelemetry.instrumentation:opentelemetry-iceberg-1.8:OPENT
 
 ### Usage
 
-The instrumentation library allows creating instrumented `Scan` (e.g., `TableScan`) instances for collecting and reporting OpenTelemetry-based sacn metrics. For example:
+The instrumentation library allows creating instrumented `Scan` (e.g., `TableScan`) instances for collecting and reporting OpenTelemetry-based scan metrics. For example:
 
 ```java
 OpenTelemetry openTelemetry = // ...

instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergMetricsReporter.java

@@ -19,7 +19,7 @@
 import org.apache.iceberg.metrics.TimerResult;
 
 public class IcebergMetricsReporter implements MetricsReporter {
-  private static final String INSTRUMENTATION_NAME = "io.opentelemetry.iceberg_1.8";
+  private static final String INSTRUMENTATION_NAME = "io.opentelemetry.iceberg-1.8";
   private static final AttributeKey<Long> SCHEMA_ID = AttributeKey.longKey("iceberg.schema.id");
   private static final AttributeKey<String> TABLE_NAME =
       AttributeKey.stringKey("iceberg.table.name");

instrumentation/iceberg-1.8/library/src/test/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergLibraryTest.java

@@ -17,7 +17,7 @@ public class IcebergLibraryTest extends AbstractIcebergTest {
 
   @Override
   protected InstrumentationExtension testing() {
-    return this.testing;
+    return testing;
   }
 
   @Override