Skip to content

Commit e8ed4e2

Browse files
authored
Fix aws timeseries requests misdetected as dynamodb (#13579)
1 parent 926d988 commit e8ed4e2

File tree

1 file changed

+18
-15
lines changed
  • instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal

1 file changed

+18
-15
lines changed

instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AwsSdkRequest.java

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,18 @@ enum AwsSdkRequest {
3838
// specific requests
3939
BatchGetItem(
4040
DYNAMODB,
41-
"BatchGetItemRequest",
41+
"dynamodb.model.BatchGetItemRequest",
4242
request("aws.dynamodb.table_names", "RequestItems"),
4343
response("aws.dynamodb.consumed_capacity", "ConsumedCapacity")),
4444
BatchWriteItem(
4545
DYNAMODB,
46-
"BatchWriteItemRequest",
46+
"dynamodb.model.BatchWriteItemRequest",
4747
request("aws.dynamodb.table_names", "RequestItems"),
4848
response("aws.dynamodb.consumed_capacity", "ConsumedCapacity"),
4949
response("aws.dynamodb.item_collection_metrics", "ItemCollectionMetrics")),
5050
CreateTable(
5151
DYNAMODB,
52-
"CreateTableRequest",
52+
"dynamodb.model.CreateTableRequest",
5353
request("aws.dynamodb.global_secondary_indexes", "GlobalSecondaryIndexes"),
5454
request("aws.dynamodb.local_secondary_indexes", "LocalSecondaryIndexes"),
5555
request(
@@ -60,29 +60,29 @@ enum AwsSdkRequest {
6060
"ProvisionedThroughput.WriteCapacityUnits")),
6161
DeleteItem(
6262
DYNAMODB,
63-
"DeleteItemRequest",
63+
"dynamodb.model.DeleteItemRequest",
6464
response("aws.dynamodb.consumed_capacity", "ConsumedCapacity"),
6565
response("aws.dynamodb.item_collection_metrics", "ItemCollectionMetrics")),
6666
GetItem(
6767
DYNAMODB,
68-
"GetItemRequest",
68+
"dynamodb.model.GetItemRequest",
6969
request("aws.dynamodb.projection_expression", "ProjectionExpression"),
7070
response("aws.dynamodb.consumed_capacity", "ConsumedCapacity"),
7171
request("aws.dynamodb.consistent_read", "ConsistentRead")),
7272
ListTables(
7373
DYNAMODB,
74-
"ListTablesRequest",
74+
"dynamodb.model.ListTablesRequest",
7575
request("aws.dynamodb.exclusive_start_table_name", "ExclusiveStartTableName"),
7676
response("aws.dynamodb.table_count", "TableNames"),
7777
request("aws.dynamodb.limit", "Limit")),
7878
PutItem(
7979
DYNAMODB,
80-
"PutItemRequest",
80+
"dynamodb.model.PutItemRequest",
8181
response("aws.dynamodb.consumed_capacity", "ConsumedCapacity"),
8282
response("aws.dynamodb.item_collection_metrics", "ItemCollectionMetrics")),
8383
Query(
8484
DYNAMODB,
85-
"QueryRequest",
85+
"dynamodb.model.QueryRequest",
8686
request("aws.dynamodb.attributes_to_get", "AttributesToGet"),
8787
request("aws.dynamodb.consistent_read", "ConsistentRead"),
8888
request("aws.dynamodb.index_name", "IndexName"),
@@ -93,7 +93,7 @@ enum AwsSdkRequest {
9393
response("aws.dynamodb.consumed_capacity", "ConsumedCapacity")),
9494
Scan(
9595
DYNAMODB,
96-
"ScanRequest",
96+
"dynamodb.model.ScanRequest",
9797
request("aws.dynamodb.attributes_to_get", "AttributesToGet"),
9898
request("aws.dynamodb.consistent_read", "ConsistentRead"),
9999
request("aws.dynamodb.index_name", "IndexName"),
@@ -107,12 +107,12 @@ enum AwsSdkRequest {
107107
response("aws.dynamodb.scanned_count", "ScannedCount")),
108108
UpdateItem(
109109
DYNAMODB,
110-
"UpdateItemRequest",
110+
"dynamodb.model.UpdateItemRequest",
111111
response("aws.dynamodb.consumed_capacity", "ConsumedCapacity"),
112112
response("aws.dynamodb.item_collection_metrics", "ItemCollectionMetrics")),
113113
UpdateTable(
114114
DYNAMODB,
115-
"UpdateTableRequest",
115+
"dynamodb.model.UpdateTableRequest",
116116
request("aws.dynamodb.attribute_definitions", "AttributeDefinitions"),
117117
request("aws.dynamodb.global_secondary_index_updates", "GlobalSecondaryIndexUpdates"),
118118
request(
@@ -121,7 +121,10 @@ enum AwsSdkRequest {
121121
request(
122122
"aws.dynamodb.provisioned_throughput.write_capacity_units",
123123
"ProvisionedThroughput.WriteCapacityUnits")),
124-
ConverseRequest(BEDROCK_RUNTIME, "ConverseRequest", request("gen_ai.request.model", "modelId"));
124+
ConverseRequest(
125+
BEDROCK_RUNTIME,
126+
"bedrockruntime.model.ConverseRequest",
127+
request("gen_ai.request.model", "modelId"));
125128

126129
private final AwsSdkRequestType type;
127130
private final String requestClass;
@@ -139,17 +142,17 @@ enum AwsSdkRequest {
139142
@Nullable
140143
static AwsSdkRequest ofSdkRequest(SdkRequest request) {
141144
// try request type
142-
AwsSdkRequest result = ofType(request.getClass().getSimpleName());
145+
AwsSdkRequest result = ofType(request.getClass().getName());
143146
// try parent - generic
144147
if (result == null) {
145-
result = ofType(request.getClass().getSuperclass().getSimpleName());
148+
result = ofType(request.getClass().getSuperclass().getName());
146149
}
147150
return result;
148151
}
149152

150153
private static AwsSdkRequest ofType(String typeName) {
151154
for (AwsSdkRequest type : values()) {
152-
if (type.requestClass.equals(typeName)) {
155+
if (typeName.endsWith(type.requestClass)) {
153156
return type;
154157
}
155158
}

0 commit comments

Comments
 (0)