Skip to content

Commit ea3e7c2

Browse files
lauritjaydeluca
andauthored
Apply suggestions from code review
Co-authored-by: Jay DeLuca <[email protected]>
1 parent f4838ed commit ea3e7c2

File tree

1 file changed

+26
-26
lines changed
  • instrumentation/jaxws/jaxws-2.0-common-testing/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxws/v2_0

1 file changed

+26
-26
lines changed

instrumentation/jaxws/jaxws-2.0-common-testing/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxws/v2_0/AbstractJaxWs2Test.java

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -110,18 +110,18 @@ void successfulRequest(TestMethod testMethod) {
110110
testing()
111111
.waitAndAssertTraces(
112112
trace -> {
113-
List<Consumer<SpanDataAssert>> assertions = new ArrayList<>();
114-
assertions.add(
115-
span ->
116-
span.hasName(serverSpanName(testMethod.methodName()))
117-
.hasNoParent()
118-
.hasKind(SpanKind.SERVER)
119-
.hasStatus(StatusData.unset()));
120-
assertions.add(
121-
span ->
122-
span.hasName("HelloService/" + testMethod.methodName())
123-
.hasParent(trace.getSpan(0))
124-
.hasKind(SpanKind.INTERNAL));
113+
List<Consumer<SpanDataAssert>> assertions =
114+
new ArrayList<>(
115+
Arrays.asList(
116+
span ->
117+
span.hasName(serverSpanName(testMethod.methodName()))
118+
.hasNoParent()
119+
.hasKind(SpanKind.SERVER)
120+
.hasStatus(StatusData.unset()),
121+
span ->
122+
span.hasName("HelloService/" + testMethod.methodName())
123+
.hasParent(trace.getSpan(0))
124+
.hasKind(SpanKind.INTERNAL)));
125125
if (hasAnnotationHandlerSpan(testMethod)) {
126126
assertions.add(
127127
span ->
@@ -152,20 +152,20 @@ void failingRequest(TestMethod testMethod) {
152152
testing()
153153
.waitAndAssertTraces(
154154
trace -> {
155-
List<Consumer<SpanDataAssert>> assertions = new ArrayList<>();
156-
assertions.add(
157-
span ->
158-
span.hasName(serverSpanName(testMethod.methodName()))
159-
.hasNoParent()
160-
.hasKind(SpanKind.SERVER)
161-
.hasStatus(StatusData.error()));
162-
assertions.add(
163-
span ->
164-
span.hasName("HelloService/" + testMethod.methodName())
165-
.hasParent(trace.getSpan(0))
166-
.hasKind(SpanKind.INTERNAL)
167-
.hasStatus(StatusData.error())
168-
.hasException(expectedException));
155+
List<Consumer<SpanDataAssert>> assertions =
156+
new ArrayList<>(
157+
Arrays.asList(
158+
span ->
159+
span.hasName(serverSpanName(testMethod.methodName()))
160+
.hasNoParent()
161+
.hasKind(SpanKind.SERVER)
162+
.hasStatus(StatusData.error()),
163+
span ->
164+
span.hasName("HelloService/" + testMethod.methodName())
165+
.hasParent(trace.getSpan(0))
166+
.hasKind(SpanKind.INTERNAL)
167+
.hasStatus(StatusData.error())
168+
.hasException(expectedException)));
169169
if (hasAnnotationHandlerSpan(testMethod)) {
170170
assertions.add(
171171
span ->

0 commit comments

Comments
 (0)