Skip to content

Commit ecad416

Browse files
committed
fix test
1 parent 5afea2c commit ecad416

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

smoke-tests-otel-starter/spring-boot-3/src/test/java/io/opentelemetry/spring/smoketest/GraalVmNativeKafkaSpringStarterSmokeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
AbstractKafkaSpringStarterSmokeTest.KafkaConfig.class
2828
},
2929
webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
30-
@EnabledInNativeImage // see JvmMongodbSpringStarterSmokeTest for the JVM test
30+
@EnabledInNativeImage // see AbstractJvmKafkaSpringStarterSmokeTest for the JVM test
3131
@RequiresDockerCompose
3232
public class GraalVmNativeKafkaSpringStarterSmokeTest extends AbstractKafkaSpringStarterSmokeTest {}

smoke-tests-otel-starter/spring-boot-3/src/test/java/io/opentelemetry/spring/smoketest/GraalVmNativeMongodbSpringStarterSmokeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
@SpringBootTest(
2424
classes = {OtelSpringStarterSmokeTestApplication.class, SpringSmokeOtelConfiguration.class},
2525
webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
26-
@EnabledInNativeImage // see JvmMongodbSpringStarterSmokeTest for the JVM test
26+
@EnabledInNativeImage // see AbstractJvmMongodbSpringStarterSmokeTest for the JVM test
2727
@RequiresDockerCompose
2828
public class GraalVmNativeMongodbSpringStarterSmokeTest
2929
extends AbstractMongodbSpringStarterSmokeTest {}

smoke-tests-otel-starter/spring-boot-common/src/main/java/io/opentelemetry/spring/smoketest/AbstractKafkaSpringStarterSmokeTest.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@
1212
import io.opentelemetry.api.common.AttributeKey;
1313
import io.opentelemetry.api.trace.SpanKind;
1414
import io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes;
15+
import io.opentelemetry.semconv.incubating.ThreadIncubatingAttributes;
1516
import org.apache.kafka.clients.admin.NewTopic;
1617
import org.apache.kafka.clients.consumer.ConsumerRecord;
18+
import org.assertj.core.api.AbstractCharSequenceAssert;
1719
import org.assertj.core.api.AbstractLongAssert;
1820
import org.assertj.core.api.AbstractStringAssert;
1921
import org.junit.jupiter.api.Test;
@@ -75,7 +77,13 @@ void shouldInstrumentProducerAndConsumer() {
7577
MessagingIncubatingAttributes.MESSAGING_KAFKA_MESSAGE_OFFSET,
7678
AbstractLongAssert::isNotNegative),
7779
equalTo(
78-
MessagingIncubatingAttributes.MESSAGING_KAFKA_MESSAGE_KEY, "10")),
80+
MessagingIncubatingAttributes.MESSAGING_KAFKA_MESSAGE_KEY, "10"),
81+
satisfies(
82+
ThreadIncubatingAttributes.THREAD_ID,
83+
AbstractLongAssert::isNotZero),
84+
satisfies(
85+
ThreadIncubatingAttributes.THREAD_NAME,
86+
AbstractCharSequenceAssert::isNotBlank)),
7987
span ->
8088
span.hasName("testTopic process")
8189
.hasKind(SpanKind.CONSUMER)

0 commit comments

Comments
 (0)