Skip to content

Commit ed58966

Browse files
authored
Review fixes for activej-http-6.0:javaagent (#16473)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 257ebe6 commit ed58966

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

instrumentation/activej-http-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejAsyncServletInstrumentation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ public static AdviceScope start(HttpRequest request) {
7474
return new AdviceScope(context, context.makeCurrent(), request);
7575
}
7676

77-
public Promise<HttpResponse> end(Promise<HttpResponse> responsePromise, Throwable throwable) {
77+
public Promise<HttpResponse> end(
78+
Promise<HttpResponse> responsePromise, @Nullable Throwable throwable) {
7879
scope.close();
79-
Promise<HttpResponse> returnValue = responsePromise;
8080
if (throwable != null) {
8181
instrumenter().end(context, httpRequest, null, throwable);
8282
return responsePromise;

instrumentation/activej-http-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerRequestGetter.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,18 @@
1616
import java.util.Iterator;
1717
import java.util.List;
1818
import java.util.Map;
19+
import javax.annotation.Nullable;
1920

20-
enum ActivejHttpServerRequestGetter implements TextMapGetter<HttpRequest> {
21-
INSTANCE;
21+
final class ActivejHttpServerRequestGetter implements TextMapGetter<HttpRequest> {
2222

2323
@Override
2424
public Iterable<String> keys(HttpRequest httpRequest) {
2525
return httpRequest.getHeaders().stream().map(h -> h.getKey().toString()).toList();
2626
}
2727

28+
@Nullable
2829
@Override
29-
public String get(HttpRequest carrier, String key) {
30+
public String get(@Nullable HttpRequest carrier, String key) {
3031
if (carrier == null) {
3132
return null;
3233
}
@@ -35,7 +36,7 @@ public String get(HttpRequest carrier, String key) {
3536
}
3637

3738
@Override
38-
public Iterator<String> getAll(HttpRequest carrier, String key) {
39+
public Iterator<String> getAll(@Nullable HttpRequest carrier, String key) {
3940
if (carrier == null) {
4041
return emptyIterator();
4142
}

instrumentation/activej-http-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerSingletons.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public final class ActivejHttpServerSingletons {
2121
JavaagentHttpServerInstrumenters.create(
2222
INSTRUMENTATION_NAME,
2323
new ActivejHttpServerAttributesGetter(),
24-
ActivejHttpServerRequestGetter.INSTANCE);
24+
new ActivejHttpServerRequestGetter());
2525
}
2626

2727
public static Instrumenter<HttpRequest, HttpResponse> instrumenter() {

0 commit comments

Comments
 (0)