Skip to content

Commit f191807

Browse files
Copilottrask
andcommitted
Add metric description assertions to RPC tests
Co-authored-by: trask <[email protected]>
1 parent 6ce81c3 commit f191807

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcClientMetricsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ void collectsMetrics() {
8080
assertThat(metric)
8181
.hasName("rpc.client.duration")
8282
.hasUnit("ms")
83+
.hasDescription("Measures the duration of outbound RPC.")
8384
.hasHistogramSatisfying(
8485
histogram ->
8586
histogram.hasPointsSatisfying(
@@ -112,6 +113,7 @@ void collectsMetrics() {
112113
assertThat(metric)
113114
.hasName("rpc.client.duration")
114115
.hasUnit("ms")
116+
.hasDescription("Measures the duration of outbound RPC.")
115117
.hasHistogramSatisfying(
116118
histogram ->
117119
histogram.hasPointsSatisfying(

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcServerMetricsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ void collectsMetrics() {
8282
assertThat(metric)
8383
.hasName("rpc.server.duration")
8484
.hasUnit("ms")
85+
.hasDescription("Measures the duration of inbound RPC.")
8586
.hasHistogramSatisfying(
8687
histogram ->
8788
histogram.hasPointsSatisfying(
@@ -113,6 +114,7 @@ void collectsMetrics() {
113114
assertThat(metric)
114115
.hasName("rpc.server.duration")
115116
.hasUnit("ms")
117+
.hasDescription("Measures the duration of inbound RPC.")
116118
.hasHistogramSatisfying(
117119
histogram ->
118120
histogram.hasPointsSatisfying(

0 commit comments

Comments
 (0)