pr feedback

Author: zeitlinger

instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameDetector.java

@@ -9,6 +9,7 @@
 import static java.util.logging.Level.FINER;
 
 import com.google.auto.service.AutoService;
+import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
 import io.opentelemetry.sdk.autoconfigure.spi.internal.ConditionalResourceProvider;
@@ -74,7 +75,11 @@ public Resource createResource(ConfigProperties config) {
     return create();
   }
 
-  Resource create() {
+  public Resource createResource(DeclarativeConfigProperties config) {
+    return create();
+  }
+
+  private Resource create() {
     logger.log(FINER, "Performing Spring Boot service name auto-detection...");
     // Note: The order should be consistent with the order of Spring matching, but noting
     // that we have "first one wins" while Spring has "last one wins".

instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceVersionDetector.java

@@ -8,6 +8,7 @@
 import static java.util.logging.Level.FINE;
 
 import com.google.auto.service.AutoService;
+import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
 import io.opentelemetry.sdk.resources.Resource;
@@ -44,7 +45,11 @@ public Resource createResource(ConfigProperties config) {
     return create();
   }
 
-  Resource create() {
+  public Resource createResource(DeclarativeConfigProperties config) {
+    return create();
+  }
+
+  private Resource create() {
     return getServiceVersionFromBuildInfo()
         .map(
             version -> {

instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/instrumentation/spring/resources/SpringResourceComponentProvider.java

@@ -33,7 +33,7 @@ public String getName() {
   @Override
   public Resource create(DeclarativeConfigProperties config) {
     return new SpringBootServiceVersionDetector()
-        .create()
-        .merge(new SpringBootServiceNameDetector().create());
+        .createResource(config)
+        .merge(new SpringBootServiceNameDetector().createResource(config));
   }
 }