@@ -394,7 +394,7 @@ Due to the changes needed on most of the instrumentation modules the migration c
394
394
we thus have to implement it in two steps:
395
395
396
396
- ` InstrumentationModule#isIndyModule ` implementation return ` true ` (and changes needed to make it indy compatible)
397
- - set ` inlined = false` on advice methods annotated with ` @Advice.OnMethodEnter ` or ` @Advice.OnMethodExit `
397
+ - set ` inline = false` on advice methods annotated with ` @Advice.OnMethodEnter ` or ` @Advice.OnMethodExit `
398
398
399
399
The ` otel.javaagent.experimental.indy ` (default ` false ` ) configuration option allows to opt-in for
400
400
using "indy". When set to ` true ` , the ` io.opentelemetry.javaagent.tooling.instrumentation.indy.AdviceTransformer `
@@ -403,7 +403,7 @@ be removed once all the instrumentations are "indy native".
403
403
404
404
This configuration is automatically enabled in CI with ` testIndy* ` checks or when the ` -PtestIndy=true ` parameter is added to gradle.
405
405
406
- In order to preserve compatibility with both instrumentation strategies, we have to omit the ` inlined = false`
406
+ In order to preserve compatibility with both instrumentation strategies, we have to omit the ` inline = false`
407
407
from the advice method annotations.
408
408
409
409
We have three sets of instrumentation modules:
@@ -445,12 +445,12 @@ return a value from the enter advice and get the value in the exit advice with a
445
445
with ` @Advice.Enter ` , for example:
446
446
447
447
``` java
448
- @Advice.OnMethodEnter (suppress = Throwable . class, inlined = false )
448
+ @Advice.OnMethodEnter (suppress = Throwable . class, inline = false )
449
449
public static Object onEnter(@Advice.Argument (1 ) Object request) {
450
450
return " enterValue" ;
451
451
}
452
452
453
- @Advice.OnMethodExit (suppress = Throwable . class, onThrowable = Throwable . class, inlined = false )
453
+ @Advice.OnMethodExit (suppress = Throwable . class, onThrowable = Throwable . class, inline = false )
454
454
public static void onExit(@Advice.Argument (1 ) Object request,
455
455
@Advice . Enter Object enterValue) {
456
456
// do something with enterValue
@@ -467,7 +467,7 @@ annotated parameters, however modifying the values is done through the advice me
467
467
and ` @Advice.AssignReturned.ToArguments ` annotation:
468
468
469
469
``` java
470
- @Advice.OnMethodEnter (suppress = Throwable . class, inlined = false )
470
+ @Advice.OnMethodEnter (suppress = Throwable . class, inline = false )
471
471
@Advice.AssignReturned.ToArguments (@ToArgument (1 ))
472
472
public static Object onEnter(@Advice.Argument (1 ) Object request) {
473
473
return " hello" ;
@@ -487,7 +487,7 @@ annotated parameter, however modifying the value is done through the advice meth
487
487
and ` @Advice.AssignReturned.ToReturned ` .
488
488
489
489
``` java
490
- @Advice.OnMethodExit (suppress = Throwable . class, inlined = false )
490
+ @Advice.OnMethodExit (suppress = Throwable . class, inline = false )
491
491
@Advice . AssignReturned . ToReturned
492
492
public static Object onExit(@Advice . Return Object returnValue) {
493
493
return " hello" ;
@@ -504,7 +504,7 @@ annotated parameter, however modifying the value is done through the advice meth
504
504
and ` @Advice.AssignReturned.ToFields ` annotation.
505
505
506
506
``` java
507
- @Advice.OnMethodEnter (suppress = Throwable . class, inlined = false )
507
+ @Advice.OnMethodEnter (suppress = Throwable . class, inline = false )
508
508
@Advice.AssignReturned.ToFields (@ToField (" fieldName" ))
509
509
public static Object onEnter(@Advice.FieldValue (" fieldName" ) Object originalFieldValue) {
510
510
return " newFieldValue" ;
0 commit comments