use _ instead of - in declarative config

Author: zeitlinger

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/DeclarativeConfigPropertiesBridge.java

@@ -133,7 +133,7 @@ private <T> T getPropertyValue(
     if (!property.startsWith(OTEL_INSTRUMENTATION_PREFIX)) {
       return null;
     }
-    String suffix = property.substring(OTEL_INSTRUMENTATION_PREFIX.length());
+    String suffix = property.substring(OTEL_INSTRUMENTATION_PREFIX.length()).replace('-', '_');
     // Split the remainder of the property on ".", and walk to the N-1 entry
     String[] segments = suffix.split("\\.");
     if (segments.length == 0) {

javaagent-extension-api/src/test/java/io/opentelemetry/javaagent/extension/DeclarativeConfigPropertiesBridgeTest.java

@@ -29,10 +29,10 @@ class DeclarativeConfigPropertiesBridgeTest {
           + "instrumentation/development:\n"
           + "  java:\n"
           + "    common:\n"
-          + "      default-enabled: true\n"
-          + "    runtime-telemetry:\n"
+          + "      default_enabled: true\n"
+          + "    runtime_telemetry:\n"
           + "      enabled: false\n"
-          + "    example-instrumentation:\n"
+          + "    example_instrumentation:\n"
           + "      string_key: value\n"
           + "      bool_key: true\n"
           + "      int_key: 1\n"

javaagent-tooling/src/test/resources/config.yaml

@@ -1,12 +1,12 @@
 instrumentation:
   java:
     common:
-      default-enabled: true
-    runtime-telemetry:
+      default_enabled: true
+    runtime_telemetry:
       enabled: false
-    external-annotations:
+    external_annotations:
       enabled: true
-    example-instrumentation:
+    example_instrumentation:
       string_key: value
       bool_key: true
       int_key: 1