Validate javaagent suppression keys

Author: trask

.github/scripts/check-javaagent-instrumentation-suppression-keys.sh

@@ -0,0 +1,54 @@
+#!/bin/bash -e
+
+# shellcheck disable=SC2044
+for file in $(find instrumentation -name "*Module.java"); do
+
+  if ! grep -q "extends InstrumentationModule" "$file"; then
+    continue
+  fi
+
+  if [[ "$file" != *"/javaagent/src/"* ]]; then
+    continue
+  fi
+
+  # shellcheck disable=SC2001
+  module_name=$(echo "$file" | sed 's#.*/\([^/]*\)/javaagent/src/.*#\1#')
+  # shellcheck disable=SC2001
+  simple_module_name=$(echo "$module_name" | sed 's/-[0-9.]*$//')
+
+  if [[ "$simple_module_name" == *jaxrs* ]]; then
+    # TODO these need some work still
+    continue
+  fi
+  if [[ "$simple_module_name" == *jaxws* ]]; then
+    # TODO these need some work still
+    continue
+  fi
+  if [[ "$simple_module_name" == jdbc ]]; then
+    # TODO split jdbc-datasource out into separate instrumentation?
+    continue
+  fi
+  if [[ "$simple_module_name" == kafka-clients ]]; then
+    # TODO split kafka client metrics out into separate instrumentation?
+    continue
+  fi
+  if [[ "$simple_module_name" == quarkus-resteasy-reactive ]]; then
+    # TODO module is missing a base version
+    continue
+  fi
+
+  if [ "$module_name" == "$simple_module_name" ]; then
+    expected="super\(\n? *\"$simple_module_name\""
+  else
+    expected="super\(\n? *\"$simple_module_name\",\n? *\"$module_name\""
+  fi
+
+  echo "$module_name"
+
+  matches=$(perl -0 -ne "print if /$expected/" "$file" | wc -l)
+  if [ "$matches" == 0 ]; then
+    echo "Expected to find $expected in $file"
+    exit 1
+  fi
+
+done

.github/workflows/build-common.yml

@@ -119,6 +119,13 @@ jobs:
             exit 1
           fi
 
+  check-suppression-keys:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - run: .github/scripts/check-javaagent-instrumentation-suppression-keys.sh
+
   build:
     runs-on: ubuntu-latest
     steps:

instrumentation/akka/akka-actor-fork-join-2.5/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkaactor/AkkaActorForkJoinInstrumentationModule.java

@@ -15,7 +15,7 @@
 @AutoService(InstrumentationModule.class)
 public class AkkaActorForkJoinInstrumentationModule extends InstrumentationModule {
   public AkkaActorForkJoinInstrumentationModule() {
-    super("akka-actor", "akka-actor-fork-join", "akka-actor-fork-join-2.5");
+    super("akka-actor-fork-join", "akka-actor-fork-join-2.5", "akka-actor");
   }
 
   @Override

instrumentation/armeria/armeria-grpc-1.14/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/armeria/grpc/v1_14/ArmeriaGrpcInstrumentationModule.java

@@ -15,7 +15,7 @@
 @AutoService(InstrumentationModule.class)
 public class ArmeriaGrpcInstrumentationModule extends InstrumentationModule {
   public ArmeriaGrpcInstrumentationModule() {
-    super("armeria", "armeria-1.14", "armeria-grpc-1.14");
+    super("armeria-grpc", "armeria-grpc-1.14", "armeria", "armeria-1.14");
   }
 
   @Override

instrumentation/clickhouse-client-0.5/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/clickhouse/ClickHouseInstrumentationModule.java

@@ -16,7 +16,7 @@
 public class ClickHouseInstrumentationModule extends InstrumentationModule {
 
   public ClickHouseInstrumentationModule() {
-    super("clickhouse", "clickhouse-client-0.5");
+    super("clickhouse-client", "clickhouse-client-0.5", "clickhouse");
   }
 
   @Override

instrumentation/elasticsearch/elasticsearch-rest-6.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v6_4/ElasticsearchRest6InstrumentationModule.java

@@ -18,7 +18,7 @@
 @AutoService(InstrumentationModule.class)
 public class ElasticsearchRest6InstrumentationModule extends InstrumentationModule {
   public ElasticsearchRest6InstrumentationModule() {
-    super("elasticsearch-rest", "elasticsearch-rest-6.0", "elasticsearch");
+    super("elasticsearch-rest", "elasticsearch-rest-6.4", "elasticsearch");
   }
 
   @Override

instrumentation/finagle-http-23.11/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/finaglehttp/v23_11/TwitterUtilCoreInstrumentationModule.java

@@ -18,7 +18,7 @@ public class TwitterUtilCoreInstrumentationModule extends InstrumentationModule
     implements ExperimentalInstrumentationModule {
 
   public TwitterUtilCoreInstrumentationModule() {
-    super("twitter-util-core");
+    super("finagle-http", "finagle-http-23.11");
   }
 
   @Override

instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/logging/ApplicationLoggingInstrumentationModule.java

@@ -17,7 +17,7 @@
 public class ApplicationLoggingInstrumentationModule extends InstrumentationModule {
 
   public ApplicationLoggingInstrumentationModule() {
-    super("internal-application-logging");
+    super("internal-application-logger");
   }
 
   @Override

instrumentation/javalin-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/javalin/v5_0/JavalinInstrumentationModule.java

@@ -19,7 +19,7 @@
 public class JavalinInstrumentationModule extends InstrumentationModule {
 
   public JavalinInstrumentationModule() {
-    super("javalin", "javalin-5");
+    super("javalin", "javalin-5.0");
   }
 
   @Override

instrumentation/kotlinx-coroutines/kotlinx-coroutines-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/KotlinCoroutinesInstrumentationModule.java

@@ -18,7 +18,7 @@ public class KotlinCoroutinesInstrumentationModule extends InstrumentationModule
     implements ExperimentalInstrumentationModule {
 
   public KotlinCoroutinesInstrumentationModule() {
-    super("kotlinx-coroutines");
+    super("kotlinx-coroutines", "kotlinx-coroutines-1.0");
   }
 
   @Override