Fix VerifyError with kotlin @WithSpan instrumentation (#9313)

Author: laurit

instrumentation/kotlinx-coroutines/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/instrumentationannotations/ExpandFramesClassVisitor.java

@@ -41,16 +41,19 @@ public void visit(
   public MethodVisitor visitMethod(
       int access, String name, String descriptor, String signature, String[] exceptions) {
     MethodVisitor mv = super.visitMethod(access, name, descriptor, signature, exceptions);
-    return new ExpandFramesMethodVisitor(mv, className, access, descriptor);
+    return new ExpandFramesMethodVisitor(mv, className, name, access, descriptor);
   }
 
   private static class ExpandFramesMethodVisitor extends MethodVisitor {
     final List<Object> currentLocals = new ArrayList<>();
     final List<Object> currentStack = new ArrayList<>();
 
-    ExpandFramesMethodVisitor(MethodVisitor mv, String className, int access, String descriptor) {
+    ExpandFramesMethodVisitor(
+        MethodVisitor mv, String className, String methodName, int access, String descriptor) {
       super(Opcodes.ASM9, mv);
-      if (!Modifier.isStatic(access)) {
+      if ("<init>".equals(methodName)) {
+        currentLocals.add(Opcodes.UNINITIALIZED_THIS);
+      } else if (!Modifier.isStatic(access)) {
         currentLocals.add(className);
       }
       for (Type type : Type.getArgumentTypes(descriptor)) {

instrumentation/kotlinx-coroutines/javaagent/src/test/kotlin/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/ClazzWithDefaultConstructorArguments.kt

@@ -0,0 +1,18 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.kotlinxcoroutines
+
+import io.opentelemetry.instrumentation.annotations.WithSpan
+import kotlinx.coroutines.delay
+
+class ClazzWithDefaultConstructorArguments(val name: String = "Ktor") {
+
+  @WithSpan
+  suspend fun sayHello(): String {
+    delay(10)
+    return "Hello World $name from ${ClazzWithDefaultConstructorArguments::class.simpleName}!"
+  }
+}

instrumentation/kotlinx-coroutines/javaagent/src/test/kotlin/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/KotlinCoroutinesInstrumentationTest.kt

@@ -559,6 +559,30 @@ class KotlinCoroutinesInstrumentationTest {
     delay(10)
   }
 
+  // regression test for https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/9312
+  @Test
+  fun `test class with default constructor argument`() {
+    runBlocking {
+      val classDefaultConstructorArguments = ClazzWithDefaultConstructorArguments()
+      classDefaultConstructorArguments.sayHello()
+    }
+
+    testing.waitAndAssertTraces(
+      { trace ->
+        trace.hasSpansSatisfyingExactly(
+          {
+            it.hasName("ClazzWithDefaultConstructorArguments.sayHello")
+              .hasNoParent()
+              .hasAttributesSatisfyingExactly(
+                equalTo(SemanticAttributes.CODE_NAMESPACE, ClazzWithDefaultConstructorArguments::class.qualifiedName),
+                equalTo(SemanticAttributes.CODE_FUNCTION, "sayHello")
+              )
+          }
+        )
+      }
+    )
+  }
+
   private fun tracedChild(opName: String) {
     tracer.spanBuilder(opName).startSpan().end()
   }