Add http.route to HTTP client requests and extract from Spring WebClient #10506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Will this PR be revisited? Is there a current practical use of #675 without the underlying HTTP client infrastructure supporting it? Is this the required implementation for it? Please check the discussion. Thank you! |
Contributor
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
Member
|
Superseded by #14612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the semantic attribute
http.routeto the list of attributes supported by HTTP client requests, indicating a templated URI used when making the HTTP request as supported by the client framework.Adds support for extracting that templated URI from the
ClientRequestattributes when using Spring WebClient. This is based on the Spring actuator implementation for Spring Boot 2.x that extracts the URI template and formats it for the purposes of reporting to Micrometer:https://github.com/spring-projects/spring-boot/blob/2.7.x/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/web/reactive/client/WebClientExchangeTags.java#L68
This implementation returns
nullif the attribute is not found to avoid reporting raw URIs.