AWS SDK request id is using `aws.requestId` instead of `aws.request_id` defined in semantic conventions

[pingleig]

Describe the bug

In semantic convention registry, the attribute name for request id is aws.request_id schema, while the SDK generated spans are using aws.requestId

Both v1 and v2 SDK are using aws.requestId

• V1 defined the attribute name in AwsExperimentalAttributes and used in AwsSdlExperimentalAtributesExtractor
• V2 hard code the attribute name in TracingExecutionInterceptor

Permlinks

v1

opentelemetry-java-instrumentation/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsExperimentalAttributes.java

Line 20 in 0c22a8e

static final AttributeKey<String> AWS_REQUEST_ID = stringKey("aws.requestId");

v2

opentelemetry-java-instrumentation/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/TracingExecutionInterceptor.java

Line 365 in 0c22a8e

span.setAttribute("aws.requestId", ((AwsResponse) response).responseMetadata().requestId());

Steps to reproduce

N/A the attribute names are defined in code. Though I found this while using Application Signal's SDK on EKS calling S3 aws-observability/aws-otel-java-instrumentation#894

Expected behavior

aws.request_id in snake_case

Actual behavior

aws.requestId in camelCase

Javaagent or library instrumentation version

N/A

Environment

N/A

Additional context

No response

[jaydeluca]

hey @pingleig, thanks for reporting this. We would welcome a contribution for this. Are you interested in contributing it? If not, I can look into it

[pingleig]

Hi @jaydeluca sorry for the late reply, seems you are already working on the fix. btw: I think the PR applies to all AWS services (in sdk v2 & v1, not just SQS right?