Db error type #13640
Merged
Db error type #13640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Apr 2, 2025
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| public class DbResponseStatusUtil { |
Contributor
There was a problem hiding this comment.
should be final, also I think it should be moved to internal package
laurit
reviewed
Apr 2, 2025
...tation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/SemconvStability.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Apr 2, 2025
instrumentation/vertx/vertx-sql-client-4.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
laurit
reviewed
Apr 3, 2025
| testLibrary("io.vertx:vertx-codegen:$version") | ||
| } | ||
|
|
||
| testing { |
Contributor
There was a problem hiding this comment.
Why do you need this suite? Try running ./gradlew :instrumentation:vertx:vertx-sql-client-4.0:javaagent:build -PtestLatestDeps=true doesn't it already run the testStableSemconv task with the latest dependency?
Member
Author
There was a problem hiding this comment.
good point - I had originally thought that the test would need to be different - but it turned out that it doesn't
Member
Author
There was a problem hiding this comment.
I was also not sure about the extend we should rely on latest dep tests for things like that
laurit
reviewed
Apr 3, 2025
instrumentation/vertx/vertx-sql-client-4.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
Member
Author
|
@laurit time for another round 😄 |
laurit
approved these changes
Apr 4, 2025
steverao
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up for #13331