-
Notifications
You must be signed in to change notification settings - Fork 1k
Open
Labels
contribution welcomeRequest makes sense, maintainers probably won't have time, contribution would be welcomeRequest makes sense, maintainers probably won't have time, contribution would be welcomeenhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem? Please describe.
// opts
-Dotel.instrumentation.jdbc.experimental.capture-query-parameters=true
// and somewhere in the code
JdbcTelemetry.create(otel).wrap(ds)
I think people will expect the opt to be enabled and get data in my spans. But as per the current implementation, JdbcTelemetryBuilder only relies on properties set explicitly such as builder.setCaptureQueryParameters(true).
I see that in OpenTelemetryDataSource there is a deprecated constructor relying on JdbcInstrumenterFactory which allows construction based on the opts. It has been deprecated with introduction of JdbcTelemetry andJdbcTelemetryBuilder.
Describe the solution you'd like
Would it be possible to provide something like JdbcTelemetry.autoConfigured(otel) for this use case or is it something that has been not allowed on purpose?
Describe alternatives you've considered
No response
Additional context
I'd be happy to implement it as soon as we have a solution!
Metadata
Metadata
Assignees
Labels
contribution welcomeRequest makes sense, maintainers probably won't have time, contribution would be welcomeRequest makes sense, maintainers probably won't have time, contribution would be welcomeenhancementNew feature or requestNew feature or request
Type
Projects
Status
Blocked