Skip to content

What to capture when Apache HttpClient 5 is passed HttpHost + absolute URI? #3697

@trask

Description

@trask

The scheme/host/port can either be captured from the HttpHost, or from the absolute URI.

I thought that we should capture the values from HttpHost since those are what's used.

But then I found that all versions except for early 4.x versions use the scheme/host/port from the absolute URI when they get back a host-relative redirect from the server.

So then I got confused, and just made the tests use the same scheme/host/port in both HttpHost and the absolute URI in order to make the redirect tests pass. But we should revisit and tighten up the tests once we decide what should be captured where.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions