Skip to content

Some netty addX(..., ChannelHandler, ...) methods aren't being instrumentedΒ #4055

@trask

Description

@trask

The netty instrumentation only applies to some of the addX methods:

.and(nameStartsWith("add"))
.and(takesArgument(1, String.class))
.and(takesArgument(2, named("io.netty.channel.ChannelHandler"))),

Some of the addX methods appear to delegate to other addX methods which are instrumented, but at least this one doesn't appear to:

ChannelPipeline addAfter(EventExecutorGroup group, String baseName, String name, ChannelHandler handler)

(it's a separate question whether we should rely on delegation)

I'm not aware of this affecting anyone, I only noticed while reviewing #4053 and wanted to track.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions