-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
The netty instrumentation only applies to some of the addX methods:
Lines 43 to 45 in ce85fd9
| .and(nameStartsWith("add")) | |
| .and(takesArgument(1, String.class)) | |
| .and(takesArgument(2, named("io.netty.channel.ChannelHandler"))), |
Some of the addX methods appear to delegate to other addX methods which are instrumented, but at least this one doesn't appear to:
ChannelPipeline addAfter(EventExecutorGroup group, String baseName, String name, ChannelHandler handler)
(it's a separate question whether we should rely on delegation)
I'm not aware of this affecting anyone, I only noticed while reviewing #4053 and wanted to track.
mateuszrzeszutek
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working