feat: Aws Lambda Request Handler instrumentation uses OTEL_INSTRUMENTATION_AWS_LAMBDA_FLUSH_TIMEOUT
#12375
Conversation
| } | ||
|
|
||
| OpenTelemetrySdkAccess.forceFlush(1, TimeUnit.SECONDS); | ||
| OpenTelemetrySdkAccess.forceFlush(flushTimeoutNanos, TimeUnit.NANOSECONDS); |
There was a problem hiding this comment.
| OpenTelemetrySdkAccess.forceFlush(flushTimeoutNanos, TimeUnit.NANOSECONDS); | |
| OpenTelemetrySdkAccess.forceFlush(flushTimeout(), TimeUnit.SECONDS); |
There was a problem hiding this comment.
OTEL_LAMBDA_FLUSH_TIMEOUT_DEFAULT is 10 seconds.
There was a problem hiding this comment.
Yes, OTEL_LAMBDA_FLUSH_TIMEOUT_DEFAULT is 10, that is a braking change from 1 second.
How to add proper changelog?
| @SuppressWarnings("unused") | ||
| public static class HandleRequestAdvice { | ||
|
|
||
| private final static long flushTimeoutNanos = flushTimeout().toNanos(); |
There was a problem hiding this comment.
| private final static long flushTimeoutNanos = flushTimeout().toNanos(); |
There was a problem hiding this comment.
I have intentionally matched the reference implementation from https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-java-instrumentation+flushTimeout.toNanos&type=code
Made it static as it is unlikely to change within the runtime, but I can make it non-static and non-final attribute if that will help.
…TATION_AWS_LAMBDA_FLUSH_TIMEOUT` Using `WrapperConfiguration.flushTimeout()` for consistency with `TracingRequestStreamWrapper`
smoke
force-pushed
the
fix/aws-lambda-java-instrumentation-force-flush-based-on-config
branch
from
90c8a46 to
757a154
Compare
| @SuppressWarnings("unused") | ||
| public static class HandleRequestAdvice { | ||
|
|
||
| private static final long flushTimeoutNanos = flushTimeout().toNanos(); |
There was a problem hiding this comment.
We don't add fields to advice classes. Either inline it or move the field to https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/awslambdacore/v1_0/AwsLambdaInstrumentationHelper.java
It would be best to keep changes here aligned with
|
superseded by #12576 |
3 participants
WrapperConfiguration.flushTimeout()for consistency withTracingRequestStreamWrapperOTEL_LAMBDA_FLUSH_TIMEOUTenv varOTEL_LAMBDA_FLUSH_TIMEOUT_DEFAULTthe flush timeout is now 10 seconds, was 1 second