Skip to content

Add missing assertInverse #12409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 17, 2024
Merged

Add missing assertInverse #12409

merged 4 commits into from
Oct 17, 2024

Conversation

@steverao
Copy link
Contributor

@steverao steverao commented Oct 8, 2024

Add missing assertInverse

@steverao steverao requested a review from a team as a code owner October 8, 2024 07:35
laurit
laurit reviewed Oct 8, 2024
View reviewed changes
laurit
laurit reviewed Oct 8, 2024
View reviewed changes
@steverao
Copy link
Contributor Author

steverao commented Oct 9, 2024

It seems there are CI failings from ktor https://scans.gradle.com/s/zi4lk2jshpphi/failure#1
e: file:///home/runner/work/opentelemetry-java-instrumentation/opentelemetry-java-instrumentation/instrumentation/ktor/ktor-2.0/library/src/test/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/server/KtorServerSpanKindExtractorTest.kt:59:12 Type mismatch: inferred type is EmbeddedServer<NettyApplicationEngine, NettyApplicationEngine.Configuration> but ApplicationEngine was expected

@trask trask merged commit 18a277f into open-telemetry:main Oct 17, 2024
56 checks passed
@steverao steverao deleted the assertInverse branch October 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

+1 more reviewer

@heyams heyams heyams left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steverao @laurit @heyams @trask