diff --git a/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/mapping/TomcatServlet3MappingTest.java b/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/mapping/TomcatServlet3MappingTest.java index 400877d8a1ea..2658f5fccadf 100644 --- a/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/mapping/TomcatServlet3MappingTest.java +++ b/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/mapping/TomcatServlet3MappingTest.java @@ -6,30 +6,28 @@ package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.mapping; import java.io.File; -import java.nio.file.Files; import java.util.UUID; import javax.servlet.Servlet; import org.apache.catalina.Context; import org.apache.catalina.LifecycleException; import org.apache.catalina.startup.Tomcat; +import org.junit.jupiter.api.io.TempDir; class TomcatServlet3MappingTest extends AbstractServlet3MappingTest { + @TempDir private static File tempDir; + @Override protected Tomcat setupServer() throws Exception { Tomcat tomcatServer = new Tomcat(); - File baseDir = Files.createTempDirectory("tomcat").toFile(); - baseDir.deleteOnExit(); + File baseDir = tempDir; tomcatServer.setBaseDir(baseDir.getAbsolutePath()); tomcatServer.setPort(port); tomcatServer.getConnector().setEnableLookups(true); // get localhost instead of 127.0.0.1 File applicationDir = new File(baseDir, "/webapps/ROOT"); - if (!applicationDir.exists()) { - applicationDir.mkdirs(); - applicationDir.deleteOnExit(); - } + applicationDir.mkdirs(); Context servletContext = tomcatServer.addWebapp(getContextPath(), applicationDir.getAbsolutePath()); diff --git a/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/tomcat/TomcatServlet3Test.java b/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/tomcat/TomcatServlet3Test.java index 69f110f3721d..72a2cacc0e4e 100644 --- a/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/tomcat/TomcatServlet3Test.java +++ b/instrumentation/servlet/servlet-3.0/testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/tomcat/TomcatServlet3Test.java @@ -23,7 +23,6 @@ import io.opentelemetry.testing.internal.armeria.common.AggregatedHttpRequest; import io.opentelemetry.testing.internal.armeria.common.AggregatedHttpResponse; import java.io.File; -import java.nio.file.Files; import java.util.ArrayList; import java.util.List; import java.util.Map; @@ -41,6 +40,7 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.RegisterExtension; +import org.junit.jupiter.api.io.TempDir; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.CsvSource; @@ -66,6 +66,8 @@ public abstract class TomcatServlet3Test extends AbstractServlet3Test