Skip to content

Small changes to servlet3 tests #12456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Small changes to servlet3 tests #12456

merged 1 commit into from
Oct 17, 2024

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented Oct 17, 2024

  • move classes used by both jetty and tomcat out of tomcat package
  • make classes that don't need to be public package private
  • for tomcat tests move registering testing extension to base class similarly to how it is for jetty tests

@laurit laurit requested a review from a team as a code owner October 17, 2024 12:49
@laurit laurit merged commit c3d8ed4 into open-telemetry:main Oct 17, 2024
56 checks passed
@laurit laurit deleted the servlet3 branch October 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeitlinger zeitlinger zeitlinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laurit @zeitlinger