Update apidiff baseline to released version 2.9.0 #12462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
approved these changes
Oct 18, 2024
trask
commented
Oct 18, 2024
Comment on lines
-168
to
+169
| echo $(git diff --cached --name-only) | ||
| echo $(git diff --cached) | ||
| git diff --cached --name-only | ||
| git diff --cached |
Member
Author
There was a problem hiding this comment.
this improved the output, so I'd suggest keeping the change
laurit
approved these changes
Oct 18, 2024
Contributor
I disabled caching for the latest release check. Maybe with this we don't need |
Member
Author
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's failing because we aren't using
--refresh-dependenciesin the CI japicmp check, but I'm reluctant to add that flag b/c then it would slow down all buildsI think it should clear itself up in <24 hours, maybe we can think of something better...