From 02d0ece418723a99938e04c06b9354c09419a09f Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 21 Oct 2024 09:46:42 -0700 Subject: [PATCH] Pin play smoke test to guice 5 --- .github/renovate.json5 | 8 ++++++++ smoke-tests/images/play/build.gradle.kts | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index 16698cc9b3e3..3b6204be20c0 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -149,6 +149,14 @@ "matchUpdateTypes": ["major"], "enabled": false }, + { + // intentionally pinning specifically to guice 5 in the play smoke test + // until we are able to test against the latest version of play + "matchFileNames": ["smoke-tests/images/play/build.gradle.kts"], + "matchPackagePrefixes": ["com.google.inject:", "com.google.inject.extensions:"], + "matchUpdateTypes": ["major"], + "enabled": false + }, { // intentionally aligning both netty 4.0 and 4.1 version in this convention "matchFileNames": ["conventions/src/main/kotlin/otel.java-conventions.gradle.kts"], diff --git a/smoke-tests/images/play/build.gradle.kts b/smoke-tests/images/play/build.gradle.kts index 0fd454211297..cd6785505053 100644 --- a/smoke-tests/images/play/build.gradle.kts +++ b/smoke-tests/images/play/build.gradle.kts @@ -27,8 +27,8 @@ dependencies { implementation("com.typesafe.play:play-guice_$scalaVer:$playVer") // Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15 // TODO (trask) remove these version overrides after updating to Play 2.9 - implementation("com.google.inject:guice:7.0.0") - implementation("com.google.inject.extensions:guice-assistedinject:7.0.0") + implementation("com.google.inject:guice:5.1.0") + implementation("com.google.inject.extensions:guice-assistedinject:5.1.0") implementation("com.typesafe.play:play-logback_$scalaVer:$playVer") implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer") }