Remove runtime scope from README.md #12521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Oct 27, 2024
| <groupId>io.opentelemetry.instrumentation</groupId> | ||
| <artifactId>opentelemetry-log4j-appender-2.17</artifactId> | ||
| <version>OPENTELEMETRY_VERSION</version> | ||
| <scope>runtime</scope> |
Member
There was a problem hiding this comment.
good catch, thanks!
can you change the gradle configuration below also?
runtimeOnly("io.opentelemetry.instrumentation:opentelemetry-log4j-appender-2.17:OPENTELEMETRY_VERSION")
to
implementation("io.opentelemetry.instrumentation:opentelemetry-log4j-appender-2.17:OPENTELEMETRY_VERSION")
Contributor
Author
There was a problem hiding this comment.
I knew that I saw "runtime" in one more place in the doc. Thanks for catching gradle one, too!
trask
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivial issue, the
runtimescope setting will prevent the user from importing the class as illustrated belowthus, the documentation has contradicting paragraphs, and the PR attempts to fix that.