Add ktor 3 instrumentation #12562
Merged
Add ktor 3 instrumentation #12562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@e5l could you take a look |
|
Sure, will check. Could you fix the PR name? |
steverao
reviewed
Nov 4, 2024
steverao
reviewed
Nov 4, 2024
...va/io/opentelemetry/javaagent/instrumentation/ktor/v3_0/KtorClientInstrumentationModule.java
Outdated
Show resolved
Hide resolved
e5l
approved these changes
Nov 5, 2024
e5l
left a comment
e5l
left a comment
There was a problem hiding this comment.
lgtm, let me know if you need help with fixing
...n/kotlin/io/opentelemetry/instrumentation/ktor/v3_0/client/KtorHttpClientSingleConnection.kt
Outdated
Show resolved
Hide resolved
...brary/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v3_0/server/KtorServerTracing.kt
Outdated
Show resolved
Hide resolved
trask
approved these changes
Nov 6, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative for #12453
Initially it seemed that krot2 and 3 instrumentations are identical, but there are some complications that require reflection to work around. Instead of trying to support both versions with the same instrumentation this PR explores having separate instrumentations with a common module for shared code.