Fix latest dep tests #12596
Merged
Fix latest dep tests #12596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Nov 8, 2024
Comment on lines
-15
to
+18
| library("io.awspring.cloud:spring-cloud-aws-starter-sqs:3.0.0") | ||
| // current latest release 3.3.0-M1 has parent that is from central because of that we can't use | ||
| // library here and have to use compileOnly + testImplementation to avoid resolving the broken | ||
| // version | ||
| compileOnly("io.awspring.cloud:spring-cloud-aws-starter-sqs:3.0.0") |
Member
There was a problem hiding this comment.
I thought only adding latestDepTestLibrary was enough to resolve this kind of issue?
Contributor
Author
There was a problem hiding this comment.
So did I. I also would have thought that we ignore versions like 3.3.0-M1. My guess is that the problem here is that what is missing is not a random dependency but one of the parent poms. Perhaps this breaks it more thoroughly than usual.
trask
approved these changes
Nov 9, 2024
| implementation("io.vertx:vertx-kafka-client:+") | ||
| implementation("io.vertx:vertx-codegen:+") | ||
| implementation("io.vertx:vertx-kafka-client:latest.release") | ||
| implementation("io.vertx:vertx-codegen:latest.release") |
Member
There was a problem hiding this comment.
was it picking up SNAPSHOT version? could you tell from where?
Contributor
Author
There was a problem hiding this comment.
no it was picking up 5.0.0.CR1, latest.release is also used by the usual latest dep magic and works with
jaydeluca
approved these changes
Nov 9, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12599
Resolves #12600