Convert some ratpack tests to java #12825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
approved these changes
Dec 12, 2024
| }); | ||
| } | ||
|
|
||
| // TODO(anuraaga): The default Ratpack error handler also returns a 500 which is all we test, so |
Member
There was a problem hiding this comment.
just a thought, but would it make sense to remove the reference to anuraaga to that someone else might be more inclined to pick up this TODO?
Member
There was a problem hiding this comment.
anyone can pick up any todo, but I agree it makes sense to remove anuraaga since no longer active in the codebase, can you send a follow-up PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7195