Add code attributes to spring webflux controller spans and remove spring-webflux.handler.type
#12887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Dec 13, 2024
...io/opentelemetry/javaagent/instrumentation/spring/webflux/v5_0/server/SpringWebfluxTest.java
Outdated
Show resolved
Hide resolved
…nstrumentation into capture-code-attributes-spring-webflux
cuichenli
changed the title
spring-webflux.handler.type
|
it looks like there's a checkstyle failure |
…nstrumentation into capture-code-attributes-spring-webflux
sorry about that, fixed it in the latest change. |
laurit
reviewed
Dec 17, 2024
| CODE_NAMESPACE, | ||
| parameter.annotatedMethod == null | ||
| ? val -> val.contains(INNER_HANDLER_FUNCTION_CLASS_TAG_PREFIX) | ||
| : val -> val.isEqualTo(TestController.class.getName()))); |
There was a problem hiding this comment.
previously used TestController is more useful than org.springframework.web.method.HandlerMethod that is reported after these changes
There was a problem hiding this comment.
now it reports TestController as class name and method name as handle, TestController does not have this method
laurit
reviewed
Dec 17, 2024
...io/opentelemetry/javaagent/instrumentation/spring/webflux/v5_0/server/SpringWebfluxTest.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Dec 19, 2024
...io/opentelemetry/javaagent/instrumentation/spring/webflux/v5_0/server/SpringWebfluxTest.java
Outdated
Show resolved
Hide resolved
…gent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/webflux/v5_0/server/SpringWebfluxTest.java Co-authored-by: Trask Stalnaker <[email protected]>
…nstrumentation into capture-code-attributes-spring-webflux
…uichenli/opentelemetry-java-instrumentation into capture-code-attributes-spring-webflux
trask
reviewed
Dec 20, 2024
Comment on lines
+28
to
+31
| if (handler instanceof HandlerMethod) { | ||
| HandlerMethod handlerMethod = (HandlerMethod) handler; | ||
| return handlerMethod.getMethod().getName(); | ||
| } |
laurit
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7345