Skip to content

Add close to fix CWE-404 #12908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add close to fix CWE-404 #12908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b973f
Add missing JarFile close to fix CWE-404
samuel-poirier Dec 17, 2024
977962c
Run spotlessApply
samuel-poirier Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/JarDetails.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,10 @@ protected Properties getPom() throws IOException {
return null;
}
Properties props = new Properties();
props.load(jarFile.getInputStream(jarEntry));
pom = props;
try (InputStream in = jarFile.getInputStream(jarEntry)) {
props.load(in);
pom = props;
}
}
}
return pom;
Expand Down
3 changes: 1 addition & 2 deletions javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ public static ClassLoader getInstance(
}

private static void includeEmbeddedExtensionsIfFound(List<URL> extensions, File javaagentFile) {
try {
JarFile jarFile = new JarFile(javaagentFile, false);
try (JarFile jarFile = new JarFile(javaagentFile, false)) {
Enumeration<JarEntry> entryEnumeration = jarFile.entries();
String prefix = "extensions/";
File tempDirectory = null;
Expand Down
Loading